From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH 1/3] PCI/sysfs: Remove resource assignment after BAR resize
Date: Mon, 9 Nov 2026 15:10:08 +0200 [thread overview]
Message-ID: <20261109131011.1815-2-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20261109131011.1815-1-ilpo.jarvinen@linux.intel.com>
pci_resize_resource() assigns the resized BAR and the other BARs it
released, or restores the original configuration on failure. Calling
pci_assign_unassigned_bus_resources() after it is redundant. If that
call manages to assign more resources in some scenario, the problem
should be fixed inside pci_resize_resource() instead.
Remove the pci_assign_unassigned_bus_resources() call from
__resource_resize_store().
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/pci/pci-sysfs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 6669e9ad5bd3..bccd0bd5091b 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -1731,7 +1731,6 @@ static ssize_t __resource_resize_store(struct device *dev, int n,
const char *buf, size_t count)
{
struct pci_dev *pdev = to_pci_dev(dev);
- struct pci_bus *bus = pdev->bus;
unsigned long size;
int ret;
u16 cmd;
@@ -1768,8 +1767,6 @@ static ssize_t __resource_resize_store(struct device *dev, int n,
pci_warn(pdev, "Failed to resize BAR %d: %pe\n",
n, ERR_PTR(ret));
- pci_assign_unassigned_bus_resources(bus);
-
if (sysfs_create_groups(&pdev->dev.kobj, pci_dev_resource_attr_groups))
pci_warn(pdev, "Failed to recreate resource groups after BAR resizing\n");
--
2.47.3
next prev parent reply other threads:[~2026-11-09 13:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 13:10 [PATCH 0/3] PCI: remove redundant resource assignments done after BAR resize Ilpo Järvinen
2026-11-09 13:10 ` Ilpo Järvinen [this message]
2026-11-09 13:17 ` [PATCH 1/3] PCI/sysfs: Remove resource assignment " sashiko-bot
2026-11-09 13:10 ` [PATCH 2/3] drm/xe: Remove driver side " Ilpo Järvinen
2026-11-09 13:15 ` sashiko-bot
2026-11-09 15:00 ` Rodrigo Vivi
2026-11-09 13:10 ` [PATCH 3/3] drm/i915: " Ilpo Järvinen
2026-11-09 13:16 ` sashiko-bot
2026-11-09 13:50 ` Joonas Lahtinen
2026-11-09 15:04 ` ✓ CI.KUnit: success for PCI: remove redundant resource assignments done " Patchwork
2026-11-09 15:37 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-09 17:10 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-11-09 22:51 ` [PATCH 0/3] " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109131011.1815-2-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=airlied@gmail.com \
--cc=bhelgaas@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.