From: Stephen Hemminger <stephen@networkplumber.org>
To: Chengwen Feng <fengchengwen@huawei.com>
Cc: <thomas@monjalon.net>, <dev@dpdk.org>
Subject: Re: [PATCH] ethdev/telemetry: fix hide_zero parameter being reset
Date: Mon, 9 Nov 2026 14:01:16 -0800 [thread overview]
Message-ID: <20261109140116.366c0760@phoenix.local> (raw)
In-Reply-To: <20261030034157.49080-1-fengchengwen@huawei.com>
On Fri, 30 Oct 2026 11:41:57 +0800
Chengwen Feng <fengchengwen@huawei.com> wrote:
> When the "hide_zero" parameter is parsed successfully in the ethdev
> telemetry regs command, the else branch unconditionally resets
> hide_zero back to false, discarding the parsed value. As a result the
> hide_zero option is silently ignored.
>
> Remove the unnecessary reset so the parsed hide_zero value is retained
> and passed to eth_dev_get_port_regs().
>
> Fixes: ba4d57bd849d ("ethdev: support hide zero in registers telemetry")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
Applied to next-net.
Note: this all gets a lot cleaner if/when the kvargs helpers get merged
https://patchwork.dpdk.org/project/dpdk/patch/20260930224340.58580-3-stephen@networkplumber.org/
prev parent reply other threads:[~2026-11-09 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 3:41 [PATCH] ethdev/telemetry: fix hide_zero parameter being reset Chengwen Feng
2026-11-05 14:25 ` Bruce Richardson
2026-11-09 22:01 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109140116.366c0760@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.