Re: [PATCH net-next 2/4] ionic: add device interface definitions for hardware monitoring

[Simon Horman <horms@kernel.org>]

On Tue, Nov 03, 2026 at 06:14:47PM +0000, Nikhil P. Rao wrote:
> From: Arun Kumar Prakash <ArunKumar.Prakash@amd.com>
> 
> Add the admin queue commands the device uses to describe and report its
> sensors: IONIC_CMD_HWMON_GETCAPS returns a buffer enumerating the sensor
> types, their channel counts and per-channel attribute capabilities, and
> IONIC_CMD_HWMON_GETATTR reads a single attribute of a single channel.
> 
> The capability buffer has a variable layout that depends on the number
> of sensor types the firmware supports, so it cannot be expressed as a C
> struct and its format is documented in a comment instead.
> 
> The sensor types, attribute IDs and capability buffer layout go in a
> new public header, include/linux/ionic/ionic_hwmon.h, because the hwmon
> driver that parses the buffer lives outside the ionic directory.
> 
> Signed-off-by: Arun Kumar Prakash <ArunKumar.Prakash@amd.com>
> Signed-off-by: Eric Joyner <eric.joyner@amd.com>
> Reviewed-by: Brett Creeley <brett.creeley@amd.com>
> Co-developed-by: Nikhil P. Rao <nikhil.rao@amd.com>
> Signed-off-by: Nikhil P. Rao <nikhil.rao@amd.com>

Reviewed-by: Simon Horman <horms@kernel.org>