Re: [PATCH v1 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad controller

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2728 bytes --]

On Tue, Nov 10, 2026 at 07:14:18PM +0800, Feng-Yi Hsueh wrote:
> Document the Nuvoton MA35D1 hardware matrix keypad controller.
> 
> The controller supports up to eight rows and eight columns
> and generates interrupts for key press and release events.
> 
> Signed-off-by: Feng-Yi Hsueh <fyhsueh4linux@gmail.com>

Most of what the bot says seems valid to implement,
pw-bot: changes-requested

Thanks,
Conor.

> ---
>  .../bindings/input/nuvoton,ma35d1-keypad.yaml | 73 +++++++++++++++++++
>  1 file changed, 73 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
> new file mode 100644
> index 000000000000..be678d0b38b9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/nuvoton,ma35d1-keypad.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton MA35D1 Matrix Keypad Controller
> +
> +maintainers:
> +  - Feng-Yi Hsueh <fyhsueh4linux@gmail.com>
> +
> +description: |
> +  The Nuvoton MA35D1 keypad controller scans a matrix of up to eight rows
> +  and eight columns and reports key press and release interrupts.
> +
> +allOf:
> +  - $ref: /schemas/input/matrix-keymap.yaml#
> +
> +properties:
> +  compatible:
> +    const: nuvoton,ma35d1-keypad
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  keypad,num-rows:
> +    minimum: 2
> +    maximum: 8
> +
> +  keypad,num-columns:
> +    minimum: 1
> +    maximum: 8
> +
> +  autorepeat:
> +    type: boolean
> +    description: Enable key autorepeat events.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - keypad,num-rows
> +  - keypad,num-columns
> +  - linux,keymap
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/input/input.h>
> +
> +    keypad@404a0000 {
> +        compatible = "nuvoton,ma35d1-keypad";
> +        reg = <0x404a0000 0x10000>;
> +        interrupts = <79>;
> +        clocks = <&clk>;
> +
> +        keypad,num-rows = <4>;
> +        keypad,num-columns = <1>;
> +        linux,keymap = <
> +            MATRIX_KEY(0, 0, KEY_1)
> +            MATRIX_KEY(1, 0, KEY_2)
> +            MATRIX_KEY(2, 0, KEY_3)
> +            MATRIX_KEY(3, 0, KEY_4)
> +        >;
> +    };
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]