From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Leitner Date: Tue, 10 Nov 2026 14:10:10 +0100 Subject: [PATCH v3 1/8] media: i2c: ov9282: handle error from exposure range update MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261110-ov9282-fixes-v3-1-cb6df80cbc22@linux.dev> References: <20261110-ov9282-fixes-v3-0-cb6df80cbc22@linux.dev> In-Reply-To: <20261110-ov9282-fixes-v3-0-cb6df80cbc22@linux.dev> To: Sakari Ailus , Dave Stevenson , Mauro Carvalho Chehab , Daniele Alessandrelli , "Paul J. Murphy" , Martina Krasteva , Richard Leitner , Hans Verkuil , Bryan O'Donoghue , Jacopo Mondi Cc: Mauro Carvalho Chehab , Gyula Kelemen , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1794316220; l=1053; i=richard.leitner@linux.dev; s=20250225; h=from:subject:message-id; bh=b3Jbh3NXBCORRMCvX19hEQQG/dyvlyW8ukNEV55mjLk=; b=0LYX0WlBpqGTpmcWQoTr02nPDBI8Qozf5gOjnEVM+uzVkF/oAlMZI5BT5QSU/HRlsNEDJHjvP S0Z7x2+EW0HBA5OoNg9mHiy0laO0w0fmlb8okJtkKr9enMoyJjgEGjN X-Developer-Key: i=richard.leitner@linux.dev; a=ed25519; pk=8hZNyyyQFqZ5ruVJsSGBSPIrmJpfDm5HwHU4QVOP1Pk= X-Endpoint-Received: by B4 Relay for richard.leitner@linux.dev/20250225 with auth_id=350 List-Id: B4 Relay Submissions When setting V4L2_CID_VBLANK the V4L2 range for the exposure control is updated by v4l2_ctrl_modify_range(). This range update missed a return value check, which resulted in ov9282_set_ctrl() not returning on an error from that function call. Fix this by checking the return value and returning it on error. Reviewed-by: Dave Stevenson Fixes: 14ea315bbeb75 ("media: i2c: Add ov9282 camera sensor driver") Cc: stable@vger.kernel.org Signed-off-by: Richard Leitner --- drivers/media/i2c/ov9282.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c index 039a47c1918cb..546b43c209097 100644 --- a/drivers/media/i2c/ov9282.c +++ b/drivers/media/i2c/ov9282.c @@ -608,6 +608,8 @@ static int ov9282_set_ctrl(struct v4l2_ctrl *ctrl) ov9282->cur_mode->height - OV9282_EXPOSURE_OFFSET, 1, OV9282_EXPOSURE_DEFAULT); + if (ret) + return ret; break; } -- 2.53.0