From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,vbabka@kernel.org,surenb@google.com,
stable@vger.kernel.org,rppt@kernel.org,peterx@redhat.com,mhocko@suse.com,
ljs@kernel.org,liam@infradead.org,david@kernel.org,umangpokhriyall@gmail.com,
akpm@linux-foundation.org
Subject: [merged mm-hotfixes-stable] userfaultfd-validate-the-whole-range-before-changing-write-protection.patch removed from -mm tree
Date: Mon, 09 Nov 2026 22:45:48 -0800 [thread overview]
Message-ID: <20261110064548.B318C1F0089F@smtp.kernel.org> (raw)
The quilt patch titled
Subject: userfaultfd: validate the whole range before changing write protection
has been removed from the -mm tree. Its filename was
userfaultfd-validate-the-whole-range-before-changing-write-protection.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Umang Pokhriyal <umangpokhriyall@gmail.com>
Subject: userfaultfd: validate the whole range before changing write protection
Date: Wed, 04 Nov 2026 15:04:57 +0530
mwriteprotect_range() checks each VMA as it walks the range. When a later
VMA is not registered for write protection, or is a hugetlb VMA the range
is not aligned to, the call fails after the earlier VMAs were already
changed. When unprotecting, userfaultfd_writeprotect() then skips
wake_userfault(), so threads blocked on those pages are not woken although
the pages are writable again.
An unprivileged process can trigger this with a range that spans an
unregistered VMA. It hasn't been seen in practice; it was found while
reviewing the userfaultfd range ioctls with an LLM.
Validate the whole range first, as mrwprotect_range() already does.
Link: https://lore.kernel.org/20261104093457.152245-1-umangpokhriyall@gmail.com
Fixes: a1b92a3f1498 ("mm/userfaultfd: support WP on multiple VMAs")
Signed-off-by: Umang Pokhriyal <umangpokhriyall@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Cc: Peter Xu <peterx@redhat.com>
Cc: David Hildenbrand <david@kernel.org>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Vlastimil Babka <vbabka@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: <stable@vger.kernel.org>
---
mm/userfaultfd.c | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
--- a/mm/userfaultfd.c~userfaultfd-validate-the-whole-range-before-changing-write-protection
+++ a/mm/userfaultfd.c
@@ -1105,21 +1105,26 @@ static int mwriteprotect_range(struct us
if (atomic_read(&ctx->mmap_changing))
goto out_unlock;
+ /*
+ * Validate every spanned VMA before changing any of them, so an
+ * invalid range is rejected without changing part of it.
+ */
err = -ENOENT;
for_each_vma_range(vmi, dst_vma, end) {
-
- if (!userfaultfd_wp(dst_vma)) {
- err = -ENOENT;
- break;
- }
+ if (!userfaultfd_wp(dst_vma))
+ goto out_unlock;
if (vma_is_hugetlb(dst_vma)) {
- err = -EINVAL;
page_mask = vma_kernel_pagesize(dst_vma) - 1;
- if ((start & page_mask) || (len & page_mask))
- break;
+ if ((start & page_mask) || (len & page_mask)) {
+ err = -EINVAL;
+ goto out_unlock;
+ }
}
+ }
+ vma_iter_set(&vmi, start);
+ for_each_vma_range(vmi, dst_vma, end) {
_start = max(dst_vma->vm_start, start);
_end = min(dst_vma->vm_end, end);
_
Patches currently in -mm which might be from umangpokhriyall@gmail.com are
reply other threads:[~2026-11-10 6:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110064548.B318C1F0089F@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=liam@infradead.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=umangpokhriyall@gmail.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.