All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjoern Doebel <doebel@amazon.de>
To: Hangbin Liu <hangbin.liu@linux.dev>
Cc: Jay Vosburgh <jv@jvosburgh.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Shuah Khan <shuah@kernel.org>, Hangbin Liu <liuhangbin@gmail.com>,
	Liang Li <liali@redhat.com>, <netdev@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] selftests: bonding: feed link monitor to deflake prio_test
Date: Tue, 10 Nov 2026 11:53:52 +0000	[thread overview]
Message-ID: <20261110115354.2250237-1-doebel@amazon.de> (raw)
In-Reply-To: <auvnnIXQV2zufxtF@fedora>

Hi Hangbin,

On Thu, Nov 05, 2026 at 10:19:08AM +0800, Hangbin Liu wrote:
> If the kill fails for some reason, will we wait here forever and hang the
> entire test?

No. bash keeps a terminated child's exit status until it is reaped, so if
the ping already exited the kill fails but the wait returns immediately.
Only a genuinely unkillable ping would block, independent of kill. The
idiomatic form is kill_process() from net/lib.sh, which short-circuits
the wait when the kill fails.

Let's disregard v1 anyway. Your question made me look again, and it only
treats a symptom: the Sashiko review was right that the mechanism in my
commit message was wrong. I'll follow-up.

pw-bot: cr

Thanks,
Bjoern

  reply	other threads:[~2026-11-10 11:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 14:20 [PATCH net] selftests: bonding: feed link monitor to deflake prio_test Bjoern Doebel
2026-11-05  2:19 ` Hangbin Liu
2026-11-10 11:53   ` Bjoern Doebel [this message]
2026-11-11  0:36     ` Hangbin Liu
2026-11-08 15:12 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110115354.2250237-1-doebel@amazon.de \
    --to=doebel@amazon.de \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hangbin.liu@linux.dev \
    --cc=jv@jvosburgh.net \
    --cc=kuba@kernel.org \
    --cc=liali@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.