From: Petr Vorel <pvorel@suse.cz>
To: Avinesh Kumar <avinesh.kumar@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] cve/ghostlock.c: Print return value and attempt in TBROK message
Date: Tue, 10 Nov 2026 16:36:18 +0100 [thread overview]
Message-ID: <20261110153618.GA707028@pevik> (raw)
In-Reply-To: <20261110152531.382231-1-avinesh.kumar@suse.com>
Hi Avinesh,
> The check after FUTEX_CMP_REQUEUE_PI breaks if the call did not fail
> with EDEADLK, but the message only said "did not return -EDEADLK" and
> TTERRNO appended errno, which is 0 when the call succeeds. The resulting
> "SUCCESS (0)" reads like a return value of 0 and hides what the call
> actually returned.
> ghostlock.c:243: TBROK: FUTEX_CMP_REQUEUE_PI did not return -EDEADLK: SUCCESS (0)
> Print TST_RET and the attempt number, so a TBROK here shows right away
> whether the call succeeded (and how many waiters it moved) or failed
> with another errno, and on which attempt it happened.
Make sense, merged.
Thank you!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2026-11-10 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 15:25 [LTP] [PATCH] cve/ghostlock.c: Print return value and attempt in TBROK message Avinesh Kumar via ltp
2026-11-10 15:36 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110153618.GA707028@pevik \
--to=pvorel@suse.cz \
--cc=avinesh.kumar@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.