From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@davidgow.net>,
Usama Arif <usamaarif642@gmail.com>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH 7.3.y 2/2] mm/damon/sysfs-schemes: drop centralized filter range arg validations
Date: Tue, 10 Nov 2026 12:15:02 -0500 [thread overview]
Message-ID: <20261110171205.2600662-2-sashal@kernel.org> (raw)
In-Reply-To: <20261110171205.2600662-1-sashal@kernel.org>
From: SJ Park <sj@kernel.org>
[ Upstream commit 1d2397b2c414e3f1fb536666ccc21d4065a3d9a6 ]
DAMON sysfs interface is validating wrong range arguments for DAMOS
filters. Now the core layer is doing the same validation. Drop the
duplicated validation in DAMON sysfs interface.
Link: https://lore.kernel.org/20260914142327.92510-6-sj@kernel.org
Signed-off-by: SJ Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@davidgow.net>
Cc: Usama Arif <usamaarif642@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
mm/damon/sysfs-schemes.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
index a997539d0e816..ece53bd0d7fdd 100644
--- a/mm/damon/sysfs-schemes.c
+++ b/mm/damon/sysfs-schemes.c
@@ -2831,27 +2831,14 @@ static int damon_sysfs_add_scheme_filters(struct damos *scheme,
}
} else if (filter->type == DAMOS_FILTER_TYPE_ADDR) {
filter->addr_range = sysfs_filter->addr_range;
- if (filter->addr_range.end <
- filter->addr_range.start) {
- damos_destroy_filter(filter);
- return -EINVAL;
- }
} else if (filter->type == DAMOS_FILTER_TYPE_TARGET) {
filter->target_idx = sysfs_filter->target_idx;
} else if (filter->type == DAMOS_FILTER_TYPE_HUGEPAGE_SIZE) {
filter->sz_range.min = sysfs_filter->range_min;
filter->sz_range.max = sysfs_filter->range_max;
- if (filter->range_min > filter->range_max) {
- damos_destroy_filter(filter);
- return -EINVAL;
- }
} else if (filter->type == DAMOS_FILTER_TYPE_PROBE_HITS_WSUM) {
filter->range_min = sysfs_filter->range_min;
filter->range_max = sysfs_filter->range_max;
- if (filter->range_min > filter->range_max) {
- damos_destroy_filter(filter);
- return -EINVAL;
- }
}
damos_add_filter(scheme, filter);
--
2.53.0
prev parent reply other threads:[~2026-11-10 17:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 10:04 FAILED: patch "[PATCH] mm/damon/sysfs-schemes: drop centralized filter range arg validations" failed to apply to 7.3-stable tree Sasha Levin
2026-11-10 17:15 ` [PATCH 7.3.y 1/2] mm/damon/sysfs-schemes: rename sysfs_filter->sz_range to range_{min,max} Sasha Levin
2026-11-10 17:15 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110171205.2600662-2-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@davidgow.net \
--cc=sj@kernel.org \
--cc=stable@vger.kernel.org \
--cc=usamaarif642@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.