From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794351671; b=t+pKooJxglbQIE/frwCFkDsr1qzHja4aMOtN3nGm23MTPSeIvy6YnB75i5H3u5RjCoGW GIjzmVKZRjdM59+R2YW6kuubXN2LZ9HkrZJcOKur2s3B7pfc8cOT5OiQfxbvoOK3hYpaZ LvNZlYaznZ10ByWxeOMCpbBSRUX8o0aZCaCM6VxsOtKGJb+eo53ONgHhF3fUOji1f6puE +OmkEd9klI14VWk5hXQiVm/VInNA+2jcHA1fy6SX7N9JQdqmNQQnBcQcNQkzVU2AK5pLo m4nUlLbd7XpdnxBkfdKuoS5BVHR50AnkwD+Nb6uA2vPAvXgB/HJnvTP0DbUc6iGlnPA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794351671; h=Received:DKIM-Signature:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=oYVduWeFdLHpkSE+FvHjAfBb/fTBb+zGdaWmZL4J7Wk=; b=DKPrXosNUC9CDIDNDDV0P99UN7AzA0LUL3I3TxqqvGjhgpT+0a5fuA3APhvLwHuS6q1d yCgbtfib2vCYtM2i8EDp32NPTieYIEb6m1DoYK5iRFbfUCH1cnS1r/7z4OwyXdFCP/WJL baWs31efHAhBvAPdRIYsIC/M847tfSCO2bL8R866TAZZgzpKjK0LuQysSwuDY6Oj5/6l6 f9LkKly4b5HdP+h6WejpsYNd3Tl+6lWwIvnZY9FsKkMNpZyoh4aPBs3XzEifF3Y+4CKjE jbFDR6oHVWKYOvm8aapD6mmXVFMnmLcZCun5wnOd77SwJkvPeeQ6vYv49Nn7EYvhlnQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=j2wbnJ7r; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E060F606A31C; Tue, 10 Nov 2026 23:01:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=j2wbnJ7r Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AF511F0093D; Tue, 10 Nov 2026 23:01:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794351670; bh=oYVduWeFdLHpkSE+FvHjAfBb/fTBb+zGdaWmZL4J7Wk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=j2wbnJ7r+jV6D2sUFFgdMC5pGUSMdi6CH9DFXl/JpqU3LmvM/RS9UjvMJfbN+Vt5T 6uG+XRcYWOSIywH/xg32gcrCKeiyyLYiFjr2QDTc7loU6hF0Nshb9m73bWG2ZZK3mk elTy3DMsvN5Urbwb2K7RZu0CKCdr+OvQjuBDknd3ssgclM7WNEY9P5o+qqxt6QnH9X 5PYHtansI+gM5fIrPJHVCp1DmmjoaIlOiJlPBxRgKKqF7oH3LabLx27zD1t0Lz13Dc lSecYCae4oyrjYK1yRu5tlCzIdLcFRddUJ05iIp9/jtMI8esq3Tl/YXEtBn0czZogg eysqhyVu3PsuA== Date: Tue, 10 Nov 2026 15:01:08 -0800 From: Eric Biggers To: Andrey Albershteyn Cc: hch@lst.de, fsverity@lists.linux.dev, dsterba@suse.com, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, brauner@kernel.org, viro@zeniv.linux.org.uk, jaegeuk@kernel.org, chao@kernel.org, tytso@mit.edu Subject: Re: [PATCH v2 4/5] ext4: use I_VERITY_BUILDING instead of private flags Message-ID: <20261110230108.GH1907@quark> References: <20261105115532.613467-1-aalbersh@kernel.org> <20261105115532.613467-5-aalbersh@kernel.org> X-Mailing-List: fsverity@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261105115532.613467-5-aalbersh@kernel.org> On Thu, Nov 05, 2026 at 12:55:29PM +0100, Andrey Albershteyn wrote: > /* > - * Write all pages (both data and verity metadata). Note that this must > - * happen before clearing EXT4_STATE_VERITY_IN_PROGRESS; otherwise pages > - * beyond i_size won't be written properly. For crash consistency, this > - * also must happen before the verity inode flag gets persisted. > + * Write all pages (both data and verity metadata). For crash > + * consistency, this also must happen before the verity inode flag gets > + * persisted. > */ > err = filemap_write_and_wait(inode->i_mapping); The deleted sentence (which wasn't deleted properly, as it left the "this also must happen" clause dangling) actually still applies. Just it should be updated to use the new flag name, or else refer to ->end_enable_verity() returning instead. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 755A8606A33F for ; Tue, 10 Nov 2026 23:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lists.sourceforge.net header.i=@lists.sourceforge.net header.a=rsa-sha256 header.s=beta header.b=ZPIrs0+m; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.a=rsa-sha256 header.s=x header.b=PeJmnZEi; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.a=rsa-sha256 header.s=x header.b=gnSVD230; dkim=neutral header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=j2wbnJ7r DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=ezc776gEawYpqQ5Djz16INRzOvVKc+nlSwKQPnkx5S8=; b=ZPIrs0+mC0LczIZxwnN/zQIkVq 7OfREqyWF6RsRGINZuhfOOvszEr9TCXEHVXXDSZeLqDjwcQfNR75Bob1NKDnSLYrjhgVFDls14JPw xb3Yv+yAq/GRmVGblfg3dzU0DkQB5snXYR8h+/BKsgJlLGVq4KB20urOXcakgY8tR1GQ=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xQuq9-000000006rV-0TEj; Tue, 10 Nov 2026 23:01:21 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xQuq7-000000006rD-1HKe for linux-f2fs-devel@lists.sourceforge.net; Tue, 10 Nov 2026 23:01:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=oYVduWeFdLHpkSE+FvHjAfBb/fTBb+zGdaWmZL4J7Wk=; b=PeJmnZEi0x0PNvTrOgU5clAjyE VnZu3gq8oqT44a8I5gNqTalxxNFgtqVG76RJTFrSteYxT9Mc9z6+kWSFTf9MT57BfBrpqeWck2I3k NH6ZjXhiRlsY7U5aW866n0+w6FMz+QhRdHeLPpZ+smfZPh0P0Sn7Plcg+t8umUsJf85M=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oYVduWeFdLHpkSE+FvHjAfBb/fTBb+zGdaWmZL4J7Wk=; b=gnSVD230cW0dpmAqoUf+hhUMHN 1RYhAPk0ZIyl1Q094THU5jlMf6DAqvS/FfyEikr6XjQhJSuRC9J9lUAt1s9eYud4Liy/uWSURt/8a 2+t7gXO6xPPvB3eRNDM3WJjzSjxuVHk5ZSSX9wHc1ZrwGrfFH0xZJu/znPpI7TtvkRzE=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xQuq4-000000004c3-0u9u for linux-f2fs-devel@lists.sourceforge.net; Tue, 10 Nov 2026 23:01:19 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id CCE7546A82; Tue, 10 Nov 2026 23:01:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AF511F0093D; Tue, 10 Nov 2026 23:01:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794351670; bh=oYVduWeFdLHpkSE+FvHjAfBb/fTBb+zGdaWmZL4J7Wk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=j2wbnJ7r+jV6D2sUFFgdMC5pGUSMdi6CH9DFXl/JpqU3LmvM/RS9UjvMJfbN+Vt5T 6uG+XRcYWOSIywH/xg32gcrCKeiyyLYiFjr2QDTc7loU6hF0Nshb9m73bWG2ZZK3mk elTy3DMsvN5Urbwb2K7RZu0CKCdr+OvQjuBDknd3ssgclM7WNEY9P5o+qqxt6QnH9X 5PYHtansI+gM5fIrPJHVCp1DmmjoaIlOiJlPBxRgKKqF7oH3LabLx27zD1t0Lz13Dc lSecYCae4oyrjYK1yRu5tlCzIdLcFRddUJ05iIp9/jtMI8esq3Tl/YXEtBn0czZogg eysqhyVu3PsuA== Date: Tue, 10 Nov 2026 15:01:08 -0800 To: Andrey Albershteyn Message-ID: <20261110230108.GH1907@quark> References: <20261105115532.613467-1-aalbersh@kernel.org> <20261105115532.613467-5-aalbersh@kernel.org> X-Archived-By: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261105115532.613467-5-aalbersh@kernel.org> X-Spam-Score: -0.2 (/) X-Headers-End: 1xQuq4-000000004c3-0u9u Subject: Re: [f2fs-dev] [PATCH v2 4/5] ext4: use I_VERITY_BUILDING instead of private flags X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: fsverity@lists.linux.dev, brauner@kernel.org, tytso@mit.edu, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, dsterba@suse.com, jaegeuk@kernel.org, linux-ext4@vger.kernel.org, hch@lst.de, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Thu, Nov 05, 2026 at 12:55:29PM +0100, Andrey Albershteyn wrote: > /* > - * Write all pages (both data and verity metadata). Note that this must > - * happen before clearing EXT4_STATE_VERITY_IN_PROGRESS; otherwise pages > - * beyond i_size won't be written properly. For crash consistency, this > - * also must happen before the verity inode flag gets persisted. > + * Write all pages (both data and verity metadata). For crash > + * consistency, this also must happen before the verity inode flag gets > + * persisted. > */ > err = filemap_write_and_wait(inode->i_mapping); The deleted sentence (which wasn't deleted properly, as it left the "this also must happen" clause dangling) actually still applies. Just it should be updated to use the new flag name, or else refer to ->end_enable_verity() returning instead. - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel