Re: [PATCH v2 6/8] spi: dt-bindings: cdns,xspi: add ADI SC846 compatible

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

On Wed, Nov 11, 2026 at 01:23:07PM +0000, Nuno Sá wrote:
> The Analog Devices ADSP-SC846 SoC integrates the Cadence xSPI controller
> with its own PHY timing configuration and with the support needed for
> the auto command (ACMD) mode with the internal DMA, so it cannot be
> described by the generic "cdns,xspi-nor" compatible. Add a SoC specific
> compatible for it.

I assume it's the phy timing that means the cdns,xspi-nor compatible
cannot be used as a fallback?

> 
> On this SoC, the controller clock and reset are always wired, so make
> them required.
> 
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
>  Documentation/devicetree/bindings/spi/cdns,xspi.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> index 3cd7321319bb..d6ac05b2efb4 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> @@ -18,6 +18,7 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - adi,adsp-sc846-xspi
>        - cdns,xspi-nor
>        - marvell,cn10-xspi-nor
>  
> @@ -53,6 +54,15 @@ required:
>  
>  allOf:
>    - $ref: spi-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: adi,adsp-sc846-xspi
> +    then:
> +      required:
> +        - clocks
> +        - resets
>    - if:
>        properties:
>          compatible:
> 
> -- 
> 2.56.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]