All of lore.kernel.org
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Maxim Kochetkov <fido_max@inbox.ru>,
	Andrew Jackson <Andrew.Jackson@arm.com>,
	Mark Brown <broonie@kernel.org>,
	Xingyu Wu <xingyu.wu@starfivetech.com>
Cc: Tim Bird <tim.bird@sony.com>,
	Yuri Zaporozhets <yuriz@vodafonemail.de>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v3 5/6] ASoC: dwc: Propagate optional IRQ lookup errors
Date: Wed, 11 Nov 2026 09:27:30 +0700	[thread overview]
Message-ID: <20261111022731.8243-6-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261111022731.8243-1-phucduc.bui@gmail.com>

From: bui duc phuc <phucduc.bui@gmail.com>

platform_get_irq_optional() can return errors other than
-EPROBE_DEFER. Propagate these errors instead of silently
continuing, while treating -ENXIO as the absence of an IRQ.

Use dev_err_probe() to report IRQ lookup failures and ensure
the reset is asserted when IRQ lookup fails.

Fixes: 564db8b8da8d ("ASoC: dwc: Propagate -EPROBE_DEFER from IRQ lookup")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---

Changes in v3:
 - Ensure the reset is asserted when IRQ lookup fails, 
   as suggested by Sashiko.
 - Add a Fixes tag

 sound/soc/dwc/dwc-i2s.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sound/soc/dwc/dwc-i2s.c b/sound/soc/dwc/dwc-i2s.c
index b0d3413c27d2..55a5dca7b79f 100644
--- a/sound/soc/dwc/dwc-i2s.c
+++ b/sound/soc/dwc/dwc-i2s.c
@@ -961,8 +961,10 @@ static int dw_i2s_probe(struct platform_device *pdev)
 	}
 
 	irq = platform_get_irq_optional(pdev, 0);
-	if (irq == -EPROBE_DEFER)
-		return irq;
+	if (irq < 0 && irq != -ENXIO) {
+		ret = dev_err_probe(&pdev->dev, irq, "failed to get IRQ\n");
+		goto err_assert_reset;
+	}
 	if (irq > 0) {
 		ret = devm_request_irq(&pdev->dev, irq, i2s_irq_handler, 0,
 				pdev->name, dev);
-- 
2.43.0


  parent reply	other threads:[~2026-11-11  2:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  2:27 [PATCH v3 0/6] ASoC: dwc: Fix several issues in the I2S driver phucduc.bui
2026-11-11  2:27 ` [PATCH v3 1/6] ASoC: dwc: Fix bit clock rate in TDM mode phucduc.bui
2026-11-11  2:27 ` [PATCH v3 2/6] ASoC: dwc: Fix error handling in dw_i2s_set_fmt() phucduc.bui
2026-11-11  2:27 ` [PATCH v3 3/6] ASoC: dwc: Fix channels_max derived from COMP_PARAM_1 phucduc.bui
2026-11-11  2:27 ` [PATCH v3 4/6] ASoC: dwc: Fix DMA fifo_size calculation phucduc.bui
2026-11-11  2:27 ` phucduc.bui [this message]
2026-11-11  2:27 ` [PATCH v3 6/6] ASoC: dwc: Remove redundant error messages phucduc.bui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111022731.8243-6-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=Andrew.Jackson@arm.com \
    --cc=broonie@kernel.org \
    --cc=fido_max@inbox.ru \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tim.bird@sony.com \
    --cc=tiwai@suse.com \
    --cc=xingyu.wu@starfivetech.com \
    --cc=yuriz@vodafonemail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.