From: Nathan Chancellor <nathan@kernel.org>
To: Shrikanth Hegde <sshegde@linux.ibm.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
Kees Cook <kees@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/smp: Handle of_property_count_u32_elems() error in parse_thread_groups()
Date: Tue, 10 Nov 2026 22:27:06 -0600 [thread overview]
Message-ID: <20261111042706.GA1385646@ax162> (raw)
In-Reply-To: <9da4b3b5-cc9d-4a55-9aba-b491f9b222e5@linux.ibm.com>
On Tue, Nov 10, 2026 at 02:58:32PM +0530, Shrikanth Hegde wrote:
> Looks fine to me.
> Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
Thanks a lot for taking a look!
> Should the similar fix is needed here as well?
>
> arch/powerpc/platforms/powernv/idle.c:
> nr_idle_states = of_property_count_u32_elems(np,
> "ibm,cpu-idle-state-flags");
>
> pnv_idle_states = kzalloc_objs(*pnv_idle_states, nr_idle_states);
> temp_u32 = kzalloc_objs(u32, nr_idle_states);
> temp_u64 = kzalloc_objs(u64, nr_idle_states);
> temp_string = kcalloc(nr_idle_states, sizeof(char *), GFP_KERNEL);
More than likely. Maybe someone from IBM can validate and send a patch.
--
Cheers,
Nathan
next prev parent reply other threads:[~2026-11-11 4:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 18:00 [PATCH] powerpc/smp: Handle of_property_count_u32_elems() error in parse_thread_groups() Nathan Chancellor
2026-11-10 9:28 ` Shrikanth Hegde
2026-11-11 4:27 ` Nathan Chancellor [this message]
2026-11-10 15:25 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111042706.GA1385646@ax162 \
--to=nathan@kernel.org \
--cc=chleroy@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=ritesh.list@gmail.com \
--cc=sshegde@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.