Re: [PATCH net-next 2/3] ipv6: add ip6_dst_lookup_flow_cookie

[Ralf Lici <ralf@mandelbit.com>]

Hi,

On Tue, 10 Nov 2026 15:29:28 -0800, Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed,  4 Nov 2026 16:53:30 +0100 Ralf Lici wrote:
> > +/**
> > + *	ip6_dst_lookup_flow_cookie - perform route lookup on flow with ipsec
> > + *				     and return the matching dst cookie
> > + *	@net: Network namespace to perform lookup in
> > + *	@sk: socket which provides route info
> > + *	@fl6: flow to lookup
> > + *	@final_dst: final destination address for ipsec lookup
> > + *	@cookie: where to store the cookie for the returned dst
> > + *
> > + *	Same as ip6_dst_lookup_flow(), but also returns the cookie describing
> > + *	the routing state the dst was obtained from. A caller caching the dst
> > + *	should use this cookie when validating it with dst_check(). If the
> > + *	IPv6 FIB changed during the lookup, a route dst no longer validates
> > + *	with it. An xfrm bundle is validated by xfrm and ignores the cookie.
> > + *
> > + *	It returns a valid dst pointer on success, or a pointer encoded
> > + *	error code.
>
> Warning: net/ipv6/ip6_output.c:1325 No description found for return value of 'ip6_dst_lookup_flow_cookie'
>
> You need to use the appropriate keyword (Return: or Returns:)
>

Yep, saw that, nonetheless I was hoping for some feedback on the general
approach, but I'll respin with the kdoc fix.

BTW is the kdoc error the reason why netdev/contest reports "Failed gate
checks"?

Thanks!

-- 
Ralf Lici
Mandelbit Srl