All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Łukasz Majewski" <lukma@nabladev.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor
Date: Wed, 11 Nov 2026 09:23:11 +0100	[thread overview]
Message-ID: <20261111092311.54928fd3@wsk> (raw)
In-Reply-To: <20b8e15f-70fb-4844-abb6-d91d7d7e9849@roeck-us.net>

Hi Guenter,

> On 11/10/26 07:02, Lukasz Majewski wrote:
> > Add "national,lm77" as compatible for the National (now TI) LM77
> > digital I2C temperature sensor.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
> > ---
> >   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > a8b2b9deade4..9413ee0626f5 100644 ---
> > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -387,6
> > +387,8 @@ properties:
> >             - national,lm85c
> >               # I2C ±0.33°C Accurate, 12-Bit + Sign Temperature
> > Sensor and Thermal Window Comparator
> >             - national,lm92
> > +            # Temperature sensor
> > +          - national,lm77  
> 
> I'd suggest to retain alphabetic order.
> 

The "alphabetic" order for "national," is already "disturbed" in this
file - that is why I've put it in the end.

Now, the question - shall I "order" properly all of "national,"
bindings in a single patch (including the new one)?

Or prepare two patches:
- One to make the alphabetic order for already in-tree properties 

and

- Add the "national,lm77" afterwards ?

> Having said that, is there any evidence that this chip is used
> on a system supporting devicetree ?

Yes, it is required for CBASE board (also send to the devicetree mailing
list for review).

> 
> Thanks,
> Guenter
> 
> >               # Nuvoton Temperature Sensor
> >             - nuvoton,w83773g
> >               # NXP ISP1301 USB transceiver  
> 



-- 
Best regards,

Lukasz Majewski

--
Nabla Software Engineering GmbH
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@nabladev.com
Managing Director : Stefano Babic

  parent reply	other threads:[~2026-11-11  8:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 15:02 [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor Lukasz Majewski
2026-11-10 15:15 ` Guenter Roeck
2026-11-10 18:31   ` Conor Dooley
2026-11-11  8:23   ` Łukasz Majewski [this message]
2026-11-11 17:53     ` Rob Herring
2026-11-12  9:14       ` Łukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111092311.54928fd3@wsk \
    --to=lukma@nabladev.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.