From: Andre Eikmeyer <dev@deq.rocks>
To: sven@kernel.org, marcel@holtmann.org, luiz.dentz@gmail.com
Cc: j@jannau.net, neal@gompa.dev, asahi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Andre Eikmeyer <dev@deq.rocks>
Subject: [PATCH v2 0/3] Bluetooth: hci_bcm4377: resume after ACPI S3 and ASPM
Date: Wed, 11 Nov 2026 13:02:45 +0100 [thread overview]
Message-ID: <20261111120248.21062-1-dev@deq.rocks> (raw)
After ACPI S3 the Bluetooth function of the BCM4377 comes back without
its firmware. Patch 2 probes it again after such a resume.
When the previous controller is still being released, the re-probe
registers the new one under another index, which runs into the probe
return check fixed in patch 1. Patch 1 is a fix on its own and goes
first.
Patch 3 is new in v2. Because of a hardware erratum the driver keeps
ASPM disabled on the whole link to the Wi-Fi and Bluetooth chip for as
long as it is bound, which holds the CPU package at PC3.
Patch 3 disables ASPM only while the firmware boots and restores it
once the firmware runs, also after the re-probe from patch 2.
The Wi-Fi function of the same chip needs the same after S3 and goes to
linux-wireless in "wifi: brcmfmac: pcie: S3 suspend and resume on the
T2 Mac chips".
Successfully ested on MacBookAir9,1 and MacBookPro15,4.
v1 [1] has not received any feedback yet.
Changes in v2:
- Add patch 3, keep ASPM off only while the firmware boots
- Patches 1 and 2 are unchanged
[1] https://lore.kernel.org/all/20261107154839.89941-1-dev@deq.rocks/
Andre Eikmeyer (3):
Bluetooth: hci_bcm4377: treat only negative hci_register_dev() returns
as errors
Bluetooth: hci_bcm4377: probe again after a resume through firmware
Bluetooth: hci_bcm4377: keep ASPM off only while the firmware boots
drivers/bluetooth/hci_bcm4377.c | 93 +++++++++++++++++++++++++++++----
1 file changed, 83 insertions(+), 10 deletions(-)
base-commit: 3f425f95ba3923d605f6a8b382e8fcdc59d479db
next reply other threads:[~2026-11-11 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 12:02 Andre Eikmeyer [this message]
2026-11-11 12:02 ` [PATCH v2 1/3] Bluetooth: hci_bcm4377: treat only negative hci_register_dev() returns as errors Andre Eikmeyer
2026-11-11 16:29 ` Sven Peter
2026-11-12 9:23 ` André Eikmeyer
2026-11-11 18:22 ` Bluetooth: hci_bcm4377: resume after ACPI S3 and ASPM bluez.test.bot
2026-11-11 12:02 ` [PATCH v2 2/3] Bluetooth: hci_bcm4377: probe again after a resume through firmware Andre Eikmeyer
2026-11-11 12:02 ` [PATCH v2 3/3] Bluetooth: hci_bcm4377: keep ASPM off only while the firmware boots Andre Eikmeyer
2026-11-11 16:31 ` Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111120248.21062-1-dev@deq.rocks \
--to=dev@deq.rocks \
--cc=asahi@lists.linux.dev \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=neal@gompa.dev \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.