Re: [LTP] [PATCH v9 1/1] cpuset_memory_spread: rewrite as a C test using the LTP cgroup library

[Petr Vorel <pvorel@suse.cz>]

Hi Changwei Zou,

...
> +static struct tst_test test = {
> +	.needs_root = 1,
> +	.needs_tmpdir = 1,
> +	.skip_filesystems = (const char *const []){ "tmpfs", "ramfs", NULL },
> +	.setup = setup,
> +	.cleanup = cleanup,
> +	.test = run,
> +	.tcnt = ARRAY_SIZE(tcases),
> +	.needs_cgroup_ctrls = (const char *const []){ "cpuset", NULL },
> +	.needs_cgroup_ver = TST_CG_V1,
> +};
> +
> +#else
> +TST_TEST_TCONF("test requires libnuma >= 2");
IMHO at least this suggestion by agent in v7 was wrong. You should have kept
using:
TST_TEST_TCONF(NUMA_ERROR_MSG);

BTW on which Ubuntu version do you test which still uses v1 and have libnuma2?

Kind regards,
Petr
> +#endif

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp