All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Gregor Herburger <gregor.herburger@linutronix.de>
Cc: "Krzysztof Kozlowski" <krzk@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Eric Anholt" <eric@anholt.net>,
	"Stefan Wahren" <wahrenst@gmx.net>,
	"Srinivas Kandagatla" <srini@kernel.org>,
	"Kees Cook" <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
	"Russell King" <linux@armlinux.org.uk>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	"Conor Dooley" <conor.dooley@microchip.com>
Subject: Re: [PATCH v9 00/12] nvmem: Add Raspberry Pi OTP nvmem driver
Date: Wed, 11 Nov 2026 09:30:49 -0600	[thread overview]
Message-ID: <20261111153049.GA2640564-robh@kernel.org> (raw)
In-Reply-To: <y2ocj374gtrwf3ozptwgmqhsy5k26y45uwlbgtyvvmlxkftc2k@gjs3jsbxbm4w>

On Wed, Nov 11, 2026 at 09:14:32AM +0100, Gregor Herburger wrote:
> On Wed, Nov 11, 2026 at 09:02:19AM +0100, Krzysztof Kozlowski wrote:
> > On 11/11/2026 08:23, Gregor Herburger wrote:
> > > Hi,
> > > 
> > > This series adds support for the Raspberry Pis OTP registers. The
> > > Raspberry Pi has one or more OTP regions. These registers are accessible
> > > through the firmware. Add a driver for it and add updates the devicetree
> > > for the Raspberry Pi 5.
> > > 
> > > ---
> > > Changes in v9:
> > > - Fix sashiko comment and use fwbuf->count instead of bytes in memcpy
> > > - Link to v8: https://patch.msgid.link/20261110-rpi-otp-driver-v8-0-797e0577d414@linutronix.de
> > > 
> > 
> > Big series sent three times within last 24 h. Please slow down and give
> > people chance to review your work.
> I sent v7 with a missing commit and based on an wrong commit so Sashiko could
> not apply the series. Sashiko found an issue in v8 so I tried to fix it in v9.
> 
> I have the impression people are not reviewing stuff as long as sashiko has
> issues. So I wanted to fix those things quick.

Like many things, depends on the maintainer...

sashiko found something on every patch? I only look at the binding 
patches, so it is not going to matter to me if sashiko points out issues 
on driver patches. Vice-versa is probably true too.

Rob

      reply	other threads:[~2026-11-11 15:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  7:23 [PATCH v9 00/12] nvmem: Add Raspberry Pi OTP nvmem driver Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 01/12] firmware: raspberrypi: reorder rpi_firmware_property_tag enum Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 02/12] soc: bcm2835: Use IS_REACHABLE for function declaration Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 03/12] nvmem: core: Enforce stride and alignment checks for nvmem_device functions Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 04/12] dt-bindings: raspberrypi,bcm2835-firmware: Add bcm2712-firmware compatible Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 05/12] nvmem: Add the Raspberry Pi OTP driver Gregor Herburger
2026-11-11  7:53   ` sashiko-bot
2026-11-11  7:23 ` [PATCH v9 06/12] firmware: raspberrypi: register nvmem driver Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 07/12] arm64: dts: broadcom: bcm2712: add raspberrypi,bcm2712-firmware compatible Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 08/12] dt-bindings: raspberrypi,bcm2835-firmware: Drop unnecessary select Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 09/12] arm64: defconfig: Enable the raspberrypi otp driver as module Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 10/12] ARM: bcm2835_defconfig: " Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 11/12] ARM: multi_v7_defconfig: " Gregor Herburger
2026-11-11  7:23 ` [PATCH v9 12/12] firmware: raspberrypi: use drvdata to register rtc driver Gregor Herburger
2026-11-11  8:02 ` [PATCH v9 00/12] nvmem: Add Raspberry Pi OTP nvmem driver Krzysztof Kozlowski
2026-11-11  8:14   ` Gregor Herburger
2026-11-11 15:30     ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111153049.GA2640564-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=florian.fainelli@broadcom.com \
    --cc=gregor.herburger@linutronix.de \
    --cc=gustavoars@kernel.org \
    --cc=kees@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=srini@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.