From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0292E606A321 for ; Wed, 11 Nov 2026 16:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jTNi9bsk Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xRAyL-0006ZT-2a; Wed, 11 Nov 2026 11:14:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRAyJ-0006Y8-Rn for qemu-devel@nongnu.org; Wed, 11 Nov 2026 11:14:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRAyI-0005xD-DK for qemu-devel@nongnu.org; Wed, 11 Nov 2026 11:14:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794413689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=bGzt4wDY3saa4Iu2U+mhDVWFqyRr3SRsaHN/1yyTmbI=; b=jTNi9bskBi2V5dlrZ7cECsFOEsiPAYiy7Ad7GDVl8PsZ246v0FNUuZDjGK6kg63GGuerjh VvfwSOY9It87g9PtLwqzPfRTWowy0u6RM5/bXh2Ga1iB0Um0Mw/9ZSCXLqYAnunG2K92Ok UKl19av11F04IVuXk/kk0J4X5+mOwo0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-DBX8b2lhMW-KTY-cB-TWJw-1; Wed, 11 Nov 2026 11:14:47 -0500 X-MC-Unique: DBX8b2lhMW-KTY-cB-TWJw-1 X-Mimecast-MFC-AGG-ID: DBX8b2lhMW-KTY-cB-TWJw_1794413686 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 577E61955BC9; Wed, 11 Nov 2026 16:14:46 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.32.37]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2D7AC1800495; Wed, 11 Nov 2026 16:14:43 +0000 (UTC) From: Thomas Huth To: Kevin Wolf , qemu-devel@nongnu.org Cc: Peter Maydell , Hanna Reitz , qemu-block@nongnu.org Subject: [PATCH] block/vhdx: Add alignment checks for region tables Date: Wed, 11 Nov 2026 17:14:42 +0100 Message-ID: <20261111161442.329763-1-thuth@redhat.com> X-Archived-By: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 According to the VHDX specification: "The FileOffset and Length fields specify the 64-bit byte offset and 32-bit byte length of the object within the file. The values must be a multiple of 1 MB, and FileOffset must be at least 1 MB." Thus let's add a sanity check to avoid that bad things could happen later. Buglink: https://gitlab.com/qemu-project/qemu/-/work_items/3762 Reported-by: Daniel Wade Signed-off-by: Thomas Huth --- block/vhdx.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/block/vhdx.c b/block/vhdx.c index 8013a90a1a4..f5beace56f5 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -566,6 +566,16 @@ vhdx_open_region_tables(BlockDriverState *bs, BDRVVHDXState *s) vhdx_region_entry_le_import(&rt_entry); + /* + * According to the VHDX spec, offset and length must be multiple + * of 1 MiB and length must be at least 1 MiB. + */ + if ((rt_entry.file_offset & (MiB - 1)) || + (rt_entry.length & (MiB - 1)) || rt_entry.length < MiB) { + ret = -EINVAL; + goto fail; + } + /* check for region overlap between these entries, and any * other memory regions in the file */ ret = vhdx_region_check(s, rt_entry.file_offset, rt_entry.length); -- 2.56.0