From: Stephen Hemminger <stephen@networkplumber.org>
To: Todd Freed <toddfreed@meta.com>
Cc: <netdev@vger.kernel.org>, David Ahern <dsahern@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
Daniel Zahka <daniel.zahka@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH iproute2-next 3/3] tc: flower: add matches psp_spi, psp_ver and psp_dev
Date: Wed, 11 Nov 2026 17:06:17 -0800 [thread overview]
Message-ID: <20261111170617.5fbde961@phoenix.local> (raw)
In-Reply-To: <20261112001512.3598626-4-toddfreed@meta.com>
On Wed, 11 Nov 2026 16:15:12 -0800
Todd Freed <toddfreed@meta.com> wrote:
> Match on the PSP Rx state of a packet the device decrypted: the SPI it
> was decrypted with (psp_spi, with an optional mask), the PSP version
> (psp_ver), and the ID of the PSP device which decrypted it (psp_dev).
>
> For example, to take the packets decrypted with one Rx SPI, from
> rx-spi-alloc, and remove their PSP state:
>
> tc filter add dev eth0 ingress protocol ipv6 flower
> psp_spi 0x80000001 psp_ver 0 psp_dev 1
> action psp decap
>
> These keys only match decrypted packets, even with a zero mask, so
> "psp_spi 0/0" matches any decrypted PSP packet.
>
> psp_spi and its mask are hexadecimal, like spi. tc-flower(8) documents
> the keys.
>
> Signed-off-by: Todd Freed <toddfreed@meta.com>
> ---
AI review feedback on this
get_u8/get_u32 use base 0 for psp_ver and psp_dev, so "psp_ver 010" is
octal. The man page documents plain numbers; base 10 would match.
Otherwise this one looks fine.
next prev parent reply other threads:[~2026-11-12 1:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 0:15 [PATCH iproute2-next 0/3] tc: add the psp action and flower psp matches Todd Freed
2026-11-12 0:15 ` [PATCH iproute2-next 1/3] uapi: add the tc psp action and flower psp keys Todd Freed
2026-11-12 0:15 ` [PATCH iproute2-next 2/3] tc: add the psp action Todd Freed
2026-11-12 1:05 ` Stephen Hemminger
2026-11-12 19:22 ` Todd Bert Freed
2026-11-12 0:15 ` [PATCH iproute2-next 3/3] tc: flower: add matches psp_spi, psp_ver and psp_dev Todd Freed
2026-11-12 1:06 ` Stephen Hemminger [this message]
2026-11-12 19:21 ` Todd Bert Freed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111170617.5fbde961@phoenix.local \
--to=stephen@networkplumber.org \
--cc=daniel.zahka@gmail.com \
--cc=dsahern@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toddfreed@meta.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.