From: Jakub Kicinski <kuba@kernel.org>
To: Alexandre Cassen <acassen@corp.free.fr>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Ido Schimmel <idosch@nvidia.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/4] net/sched: honor TCA_ACT_FLAGS_NO_PERCPU_STATS in bpf, ife and skbmod
Date: Wed, 11 Nov 2026 17:22:38 -0800 [thread overview]
Message-ID: <20261111172238.506fb9ce@kernel.org> (raw)
In-Reply-To: <20261109124618.933149-3-acassen@corp.free.fr>
On Mon, 9 Nov 2026 13:46:13 +0100 Alexandre Cassen wrote:
> - ret = tcf_idr_create(tn, index, est, act,
> - &act_bpf_ops, bind, true, flags);
> + ret = tcf_idr_create_from_flags(tn, index, est, act,
> + &act_bpf_ops, bind, flags);
Now that we modified all actions could you take a look at removing
the unnecessary API variants? tcf_idr_create() has one remaining
caller AFAICT, so we can probably rename tcf_idr_create_from_flags()
back to tcf_idr_create() and make using flags the default?
next prev parent reply other threads:[~2026-11-12 1:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 12:46 [PATCH net-next v3 0/4] net/sched: let actions drop their per CPU memory Alexandre Cassen
2026-11-09 12:46 ` [PATCH net-next v3 1/4] net/sched: honor TCA_ACT_FLAGS_NO_PERCPU_STATS in more actions Alexandre Cassen
2026-11-09 12:46 ` [PATCH net-next v3 2/4] net/sched: honor TCA_ACT_FLAGS_NO_PERCPU_STATS in bpf, ife and skbmod Alexandre Cassen
2026-11-12 1:22 ` Jakub Kicinski [this message]
2026-11-12 9:06 ` Alexandre Cassen
2026-11-09 12:46 ` [PATCH net-next v3 3/4] net/sched: act_api: pass the filter offload flags to action init Alexandre Cassen
2026-11-09 12:46 ` [PATCH net-next v3 4/4] net/sched: act_tunnel_key: skip dst cache for skip_sw actions Alexandre Cassen
2026-11-12 1:30 ` [PATCH net-next v3 0/4] net/sched: let actions drop their per CPU memory patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111172238.506fb9ce@kernel.org \
--to=kuba@kernel.org \
--cc=acassen@corp.free.fr \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=ihor.solodrai@linux.dev \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.