From: Jakub Kicinski <kuba@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: houminxi@gmail.com, netdev@vger.kernel.org,
donald.hunter@gmail.com, davem@davemloft.net,
edumazet@kernel.org, pabeni@redhat.com, horms@kernel.org,
aconole@redhat.com, echaudro@redhat.com, i.maximets@ovn.org,
dev@openvswitch.org
Subject: Re: [PATCH net-next v7 1/2] netlink: specs: add ovs_flow del and set operations
Date: Wed, 11 Nov 2026 18:05:05 -0800 [thread overview]
Message-ID: <20261111180505.530e85f3@kernel.org> (raw)
In-Reply-To: <179444894546.2199510.2728310247051508293@kernel.org>
On Thu, 12 Nov 2026 02:02:25 +0000 netdev-bot+sashiko@kernel.org wrote:
> > + value of the OVS_FLOW_ATTR_KEY attribute. A value longer than 16
> > + octets is treated as if the attribute were absent, so a new flow is
> > + indexed by its key. A zero-length value is rejected with -ERANGE.
> > + Optional for all requests. Present in notifications if the flow was
> > + created with this attribute. A dump does not read it.
>
> [Severity: Low]
> Is "A dump does not read it" accurate when it sits next to the -ERANGE
> sentence? The commit message goes further:
>
> "A dump does not read the attribute at all."
Please don't over-describe things if the description isn't 100%
correct.. IDK if you added this here based on previous AI feedback
but if so - please feel free to ignore the AI feedback about
documenting things. It's often wrong / leading down the wrong path.
next prev parent reply other threads:[~2026-11-12 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 17:47 [PATCH net-next v7 0/2] netlink: specs: fill in the missing ovs operations Minxi Hou
2026-11-10 17:47 ` [PATCH net-next v7 1/2] netlink: specs: add ovs_flow del and set operations Minxi Hou
2026-11-12 2:02 ` netdev-bot+sashiko
2026-11-12 2:05 ` Jakub Kicinski [this message]
2026-11-10 17:47 ` [PATCH net-next v7 2/2] netlink: specs: add ovs datapath and vport " Minxi Hou
2026-11-12 2:02 ` netdev-bot+sashiko
2026-11-12 2:03 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111180505.530e85f3@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=donald.hunter@gmail.com \
--cc=echaudro@redhat.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=houminxi@gmail.com \
--cc=i.maximets@ovn.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.