From: Jakub Kicinski <kuba@kernel.org>
To: Hanson Wang <hanson.wang@ugreen.com>
Cc: netdev@vger.kernel.org, Sukhdeep Singh <sukhdeeps@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH net v3] net: atlantic: stop TX again before freeing rings
Date: Wed, 11 Nov 2026 18:17:37 -0800 [thread overview]
Message-ID: <20261111181737.3b2e56dc@kernel.org> (raw)
In-Reply-To: <20261109071935.2945421-1-hanson.wang@ugreen.com>
On Mon, 9 Nov 2026 15:19:35 +0800 Hanson Wang wrote:
> + /* Drain external XDP transmitters that passed the admission gate.
> + * They can wake TX queues, so wait before the final queue stop.
> + */
> + synchronize_net();
Is this really needed? presumably you removed a NAPI at some point which
implies a RCU sync.
> + /* Service work, IRQs, NAPI and external XDP can no longer wake
> + * queues. Drain SKB transmit before aq_nic_deinit() frees rings.
> + */
> + netif_tx_disable(self->ndev);
> + netif_carrier_off(self->ndev);
Double-stopping is pretty hacky. Can you figure out a way of avoiding
the race instead of stopping the queues twice?
--
pw-bot: cr
prev parent reply other threads:[~2026-11-12 2:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 7:19 [PATCH net v3] net: atlantic: stop TX again before freeing rings Hanson Wang
2026-11-12 2:17 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111181737.3b2e56dc@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hanson.wang@ugreen.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=sukhdeeps@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.