From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Hungyu Lin <dennylin0707@gmail.com>,
davem@davemloft.net, edumazet@kernel.org, pabeni@redhat.com,
horms@kernel.org, n05ec@lzu.edu.cn, ylong030@ucr.edu,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] vlan: prevent cross-netns MII register writes
Date: Thu, 12 Nov 2026 11:35:50 -0800 [thread overview]
Message-ID: <20261112113550.016cdab3@kernel.org> (raw)
In-Reply-To: <bc45c1e8-6904-47f7-9c96-512e024c9d71@gmail.com>
On Thu, 12 Nov 2026 09:42:32 -0800 Florian Fainelli wrote:
> >> Andrew, Florian, any idea if we could delete this completely?
> >> Why would anyone want to run MII/PHY commands on a VLAN?
> >
> > It does seem questionable.
>
> Agreed, it does not quite make sense to me to forward these ioctl()
> calls. Looks like this predates the import of Linux-2.6.12-rc2 into git,
> need to do some more history digging to find out why this was done.
Maybe we can just delete it in -next and see if anyone complains?
The "fix" as posted would have to go to -next too, given regression
potential, so if we can't think of a use case let's try the bigger
hammer?
prev parent reply other threads:[~2026-11-12 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 12:46 [PATCH net] vlan: prevent cross-netns MII register writes Hungyu Lin
2026-11-06 12:51 ` netdev-bot+sinfo
2026-11-10 13:04 ` netdev-bot+sashiko
[not found] ` <20261112075624.23c04230@kernel.org>
2026-11-12 16:15 ` Andrew Lunn
2026-11-12 17:42 ` Florian Fainelli
2026-11-12 19:35 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112113550.016cdab3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dennylin0707@gmail.com \
--cc=edumazet@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n05ec@lzu.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ylong030@ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.