From: Christoph Hellwig <hch@lst.de>
To: Hengyu Liang <hengyul@cs.unc.edu>
Cc: fstests@vger.kernel.org, Zorro Lang <zlang@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: test that statfs does not report negative free blocks
Date: Thu, 12 Nov 2026 16:53:31 +0100 [thread overview]
Message-ID: <20261112155331.GA32171@lst.de> (raw)
In-Reply-To: <20261112154917.751315-1-hengyul@cs.unc.edu>
On Thu, Nov 12, 2026 at 10:49:17AM -0500, Hengyu Liang wrote:
> +# Only the data device counters are checked.
> +_disable_scratch_realtime
> +
> +_scratch_mkfs >> $seqres.full 2>&1
> +_scratch_mount
> +_require_xfs_scratch_non_zoned
Why do you need _require_xfs_scratch_non_zoned? If this test is always
working on the data volume due to disable_scratch_realtime above,
a zoned vs non-zoned RT volume shouldn't matter unless I'm missing
something.
Otherwise this looks good to me, thanks a lot!
next prev parent reply other threads:[~2026-11-12 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 15:49 [PATCH] xfs: test that statfs does not report negative free blocks Hengyu Liang
2026-11-12 15:53 ` Christoph Hellwig [this message]
2026-11-12 17:33 ` Hengyu Liang
2026-11-12 17:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112155331.GA32171@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hengyul@cs.unc.edu \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.