All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Roach <jeff.roach0@gmail.com>
To: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Abel Vesa <abelvesa@kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	David Collins <david.collins@oss.qualcomm.com>,
	Subbaraman Narayanamurthy
	<subbaraman.narayanamurthy@oss.qualcomm.com>,
	Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
	Tingguo Cheng <tingguo.cheng@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-rtc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] soc: qcom: pmic_glink: Add GIO pmic_glink instance
Date: Thu, 12 Nov 2026 15:11:38 -0600	[thread overview]
Message-ID: <20261112211138.40217-1-jeff.roach0@gmail.com> (raw)
In-Reply-To: <9d80c088-1a0e-48fc-9a24-09fa8c281cd7@oss.qualcomm.com>

On 11/12/2026 3:10 PM, Fenglin Wu wrote:
> Could you try this on your side? If it works there as well, I can
> discuss it with the firmware team and come up with a formal fix when
> pushing next patch.

Tried your diff (pmic_glink_gio_enable_alerts() not called) on the
HP OmniBook X 16 (Mahua). It works:

- UCSI is fine again: no PPM init timeout at boot, and plug/unplug on
  both USB-C ports creates/removes port*-partner as expected.
- Charging works on both ports, and a USB 3 stick enumerates at
  SuperSpeed on both ports.
- RTC via GIO reads correct UTC.

Please disregard the plug/unplug sound problem from my mail yesterday.
With the GIO modules loaded, qcom-battmgr-usb never gets a change
uevent, but the sound works anyway on both ports when the laptop
starts after a long power-off with the charger unplugged. So that
uevent is not what drives it. My guess is the earlier failures came
from leaving the charger plugged in, or from power-offs too short
(about 10 s to 40 s) to reset the charger state between test boots.

Jeff

  reply	other threads:[~2026-11-12 21:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11  3:28 [PATCH 0/3] soc: qcom: Add Qualcomm PMIC GIO framework and RTC driver using it Fenglin Wu
2026-11-11  3:28 ` [PATCH 1/3] soc: qcom: Add pmic-gio GIO framework driver Fenglin Wu
2026-11-11  3:47   ` sashiko-bot
2026-11-11  3:28 ` [PATCH 2/3] soc: qcom: pmic_glink: Add GIO pmic_glink instance Fenglin Wu
2026-11-11  4:07   ` sashiko-bot
2026-11-11 13:14   ` Jeff Roach
2026-11-11 13:41     ` Jeff Roach
2026-11-12  1:11     ` Fenglin Wu
2026-11-12  7:10       ` Fenglin Wu
2026-11-12 21:11         ` Jeff Roach [this message]
2026-11-11  3:28 ` [PATCH 3/3] rtc: Add Qualcomm GIO RTC driver Fenglin Wu
2026-11-11  4:20   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112211138.40217-1-jeff.roach0@gmail.com \
    --to=jeff.roach0@gmail.com \
    --cc=abelvesa@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andersson@kernel.org \
    --cc=david.collins@oss.qualcomm.com \
    --cc=fenglin.wu@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=subbaraman.narayanamurthy@oss.qualcomm.com \
    --cc=tingguo.cheng@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.