From: Rob Herring <robh@kernel.org>
To: Linghui Wu <linghui.wu@oss.qualcomm.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Abel Vesa" <abelvesa@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Sushrut Shree Trivedi" <sushrut.trivedi@oss.qualcomm.com>,
"Miaoqing Pan" <miaoqing.pan@oss.qualcomm.com>,
"Hangtian Zhu" <hangtian.zhu@oss.qualcomm.com>,
"Shuai Zhang" <shuai.zhang@oss.qualcomm.com>,
"Cheng Jiang" <cheng.jiang@oss.qualcomm.com>,
"Wei Deng" <wei.deng@oss.qualcomm.com>,
linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: PCI: qcom: document the Shikra PCIe controller
Date: Thu, 12 Nov 2026 16:40:39 -0600 [thread overview]
Message-ID: <20261112224039.GA1755530-robh@kernel.org> (raw)
In-Reply-To: <20261112083355.3884737-2-linghui.wu@oss.qualcomm.com>
On Thu, Nov 12, 2026 at 04:33:52PM +0800, Linghui Wu wrote:
> From: Sushrut Shree Trivedi <sushrut.trivedi@oss.qualcomm.com>
>
> Add a dedicated schema for the PCIe controller found on Shikra.
>
> Signed-off-by: Sushrut Shree Trivedi <sushrut.trivedi@oss.qualcomm.com>
> ---
> .../devicetree/bindings/arm/qcom-soc.yaml | 1 +
> .../bindings/pci/qcom,pcie-shikra.yaml | 192 ++++++++++++++++++
> 2 files changed, 193 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie-shikra.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index 179aadc86a9f..72e0f1a824c6 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -43,6 +43,7 @@ properties:
> - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
> - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
> - pattern: "^qcom,(eliza|kaanapali|kuno|glymur|hawi|mahua|maili|milos|nord|shikra)-.+$"
> + - const: qcom,pcie-shikra
Pretty sure we don't want this. Surely this was pointed out before v5.
>
> # Legacy namings - variations of existing patterns/compatibles are OK,
> # but do not add completely new entries to these:
next prev parent reply other threads:[~2026-11-12 22:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 8:33 [PATCH v5 0/4] PCI: qcom: add Shikra PCIe and M.2 Wi-Fi/BT support Linghui Wu
2026-11-12 8:33 ` [PATCH v5 1/4] dt-bindings: PCI: qcom: document the Shikra PCIe controller Linghui Wu
2026-11-12 8:54 ` sashiko-bot
2026-11-12 22:40 ` Rob Herring [this message]
2026-11-12 8:33 ` [PATCH v5 2/4] PCI: qcom: add support for " Linghui Wu
2026-11-12 8:47 ` sashiko-bot
2026-11-12 8:33 ` [PATCH v5 3/4] arm64: dts: qcom: shikra: add PCIe PHY and controller nodes Linghui Wu
2026-11-12 8:56 ` sashiko-bot
2026-11-12 8:33 ` [PATCH v5 4/4] arm64: dts: qcom: shikra-iqs: add M.2 Wi-Fi and Bluetooth overlay Linghui Wu
2026-11-12 9:05 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112224039.GA1755530-robh@kernel.org \
--to=robh@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=cheng.jiang@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=hangtian.zhu@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linghui.wu@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=miaoqing.pan@oss.qualcomm.com \
--cc=shuai.zhang@oss.qualcomm.com \
--cc=sushrut.trivedi@oss.qualcomm.com \
--cc=wei.deng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.