From: Eric Biggers <ebiggers@kernel.org>
To: Antonio Quartulli <antonio@openvpn.net>
Cc: linux-crypto@vger.kernel.org,
Antonio Quartulli <antonio@mandelbit.com>,
Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [RFC PATCH 1/5] lib/crypto: tests: Make the AEAD dst clearing check effective
Date: Thu, 12 Nov 2026 19:07:28 -0800 [thread overview]
Message-ID: <20261113030728.GB1742@sol> (raw)
In-Reply-To: <20261112125432.3064939-2-antonio@openvpn.net>
On Thu, Nov 12, 2026 at 01:54:26PM +0100, Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@mandelbit.com>
>
> The basic validation test checks that decryption clears dst on
> authentication failure, but its plaintext is all zeroes, so a
> decryption that leaves the recovered plaintext in dst passes the check
> too. Use a random plaintext instead.
>
> Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
> ---
> lib/crypto/tests/aead-test-template.h | 5 +++++
> 1 file changed, 5 insertions(+)
Good catch, thanks! I applied this patch to libcrypto-next.
- Eric
next prev parent reply other threads:[~2026-11-13 3:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 12:54 [RFC PATCH 0/5] lib/crypto: Add AEGIS-128X4 Antonio Quartulli
2026-11-12 12:54 ` [RFC PATCH 1/5] lib/crypto: tests: Make the AEAD dst clearing check effective Antonio Quartulli
2026-11-13 3:07 ` Eric Biggers [this message]
2026-11-12 12:54 ` [RFC PATCH 2/5] lib/crypto: aegis128x4: Add AEGIS-128X4 library Antonio Quartulli
2026-11-12 12:54 ` [RFC PATCH 3/5] lib/crypto: tests: Add KUnit test suite for AEGIS-128X4 Antonio Quartulli
2026-11-12 12:54 ` [RFC PATCH 4/5] lib/crypto: x86/aegis128x4: Add VAES-AVX512 optimized code Antonio Quartulli
2026-11-12 12:54 ` [RFC PATCH 5/5] crypto: aegis128x4 - Add AEGIS-128X4 AEAD algorithm Antonio Quartulli
2026-11-12 16:20 ` [RFC PATCH 0/5] lib/crypto: Add AEGIS-128X4 Ard Biesheuvel
2026-11-12 16:44 ` Jason A. Donenfeld
2026-11-12 22:54 ` Antonio Quartulli
2026-11-13 2:06 ` Eric Biggers
2026-11-12 16:50 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113030728.GB1742@sol \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=antonio@mandelbit.com \
--cc=antonio@openvpn.net \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.