From: kernel test robot <lkp@intel.com>
To: Jack Wang <jinpu.wang@cloud.ionos.com>, Yu Kuai <yukuai@fygo.io>,
Song Liu <song@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Li Nan <magiclinan@didiglobal.com>, Xiao Ni <xiao@kernel.org>,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] block: suspend bio based disks around queue limits updates
Date: Fri, 13 Nov 2026 04:09:18 +0800 [thread overview]
Message-ID: <202611130320.U910h0Q4-lkp@intel.com> (raw)
In-Reply-To: <20261112134700.372702-2-jinpu.wang@cloud.ionos.com>
Hi Jack,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4]
url: https://github.com/intel-lab-lkp/linux/commits/Jack-Wang/block-suspend-bio-based-disks-around-queue-limits-updates/20261112-144659
base: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
patch link: https://lore.kernel.org/r/20261112134700.372702-2-jinpu.wang%40cloud.ionos.com
patch subject: [PATCH v4 1/2] block: suspend bio based disks around queue limits updates
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20261113/202611130320.U910h0Q4-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 1b1fed44d3dcca649a9877915d57c3357a98124e)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261113/202611130320.U910h0Q4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611130320.U910h0Q4-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from block/blk-integrity.c:18:
block/blk.h:680:10: warning: releasing mutex 'disk->queue->limits_lock' that was not held [-Wthread-safety-analysis]
680 | return queue_limits_commit_update(disk->queue, lim);
| ^
block/blk.h:681:9: warning: releasing mutex 'disk->queue->limits_lock' that was not held [-Wthread-safety-analysis]
681 | return queue_limits_commit_update_frozen(disk->queue, lim);
| ^
>> block/blk-integrity.c:255:1: warning: mutex '(dev - #undefined)->bd_disk->queue->limits_lock' is not held on every path through here [-Wthread-safety-analysis]
255 | }
| ^
block/blk-integrity.c:244:8: note: mutex acquired here
244 | lim = queue_limits_start_update(q);
| ^
3 warnings generated.
vim +255 block/blk-integrity.c
e9f5f44ad372533 Christoph Hellwig 2024-06-13 225
b83bd486b43d2b7 Kanchan Joshi 2024-06-17 226 static ssize_t flag_store(struct device *dev, const char *page, size_t count,
b83bd486b43d2b7 Kanchan Joshi 2024-06-17 227 unsigned char flag)
1366251a794b149 Christoph Hellwig 2024-06-13 228 {
9a7e3243fd42730 Jack Wang 2026-11-12 229 struct gendisk *disk = dev_to_disk(dev);
9a7e3243fd42730 Jack Wang 2026-11-12 230 struct request_queue *q = disk->queue;
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 231 struct queue_limits lim;
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 232 unsigned long val;
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 233 int err;
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 234
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 235 err = kstrtoul(page, 10, &val);
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 236 if (err)
1d59857ed2ec4d5 Christoph Hellwig 2024-06-13 237 return err;
1366251a794b149 Christoph Hellwig 2024-06-13 238
9a7e3243fd42730 Jack Wang 2026-11-12 239 err = blk_disk_suspend(disk);
9a7e3243fd42730 Jack Wang 2026-11-12 240 if (err)
9a7e3243fd42730 Jack Wang 2026-11-12 241 return err;
9a7e3243fd42730 Jack Wang 2026-11-12 242
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 243 /* note that the flags are inverted vs the values in the sysfs files */
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 244 lim = queue_limits_start_update(q);
1366251a794b149 Christoph Hellwig 2024-06-13 245 if (val)
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 246 lim.integrity.flags &= ~flag;
9f4aa46f2a74010 Christoph Hellwig 2024-06-13 247 else
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 248 lim.integrity.flags |= flag;
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 249
9a7e3243fd42730 Jack Wang 2026-11-12 250 err = blk_disk_commit_limits(disk, &lim);
9a7e3243fd42730 Jack Wang 2026-11-12 251 blk_disk_resume(disk);
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 252 if (err)
c6e56cf6b2e79a4 Christoph Hellwig 2024-06-13 253 return err;
1366251a794b149 Christoph Hellwig 2024-06-13 254 return count;
1366251a794b149 Christoph Hellwig 2024-06-13 @255 }
1366251a794b149 Christoph Hellwig 2024-06-13 256
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-11-12 20:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 13:46 [PATCH v4 0/2] block, md: suspend md around queue limits updates Jack Wang
2026-11-12 13:46 ` [PATCH v4 1/2] block: suspend bio based disks " Jack Wang
2026-11-12 14:04 ` sashiko-bot
2026-11-12 19:17 ` kernel test robot
2026-11-12 20:09 ` kernel test robot [this message]
2026-11-12 13:47 ` [PATCH v4 2/2] md: suspend the array instead of freezing the queue for " Jack Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202611130320.U910h0Q4-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=magiclinan@didiglobal.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=song@kernel.org \
--cc=xiao@kernel.org \
--cc=yukuai@fygo.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.