From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.210 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794554204; b=geAiXvaU8jfxlmNSCXuPqvUBeLDM99P8qmIzINnmiGjWx/Ruih2u8vWrguNBIn46Wa6C 8CG0gAdLcJirR4KtR/1BoaQheiDBDAaB+hEd/FZJ0sxL50gHX948DgoQPbhyxhNc8b608 0s1KtWcmVRBhon6JuXQYufHNMsoVNG0x5ybkRFSHY6gl7f/aGcLYcSTiZwEF6RjIWiloT +xPdg1d6/gdHMcqR7doqNM3IT24SNW0UY4LvuRGjCtRlVf5p4VPzF+VCWKDaBnv4GB3vt 1r5zZAG2gS1nCWEkzUzvAz/+91eyMrRLDSLSU1WE1THTXgQZty6aRtUibel6sxZdv3g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794554204; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=SlgWhN9GaJLMebYSO8+fABWRsOhCLV84A5VqjbhON4E=; b=T/nYxBcrl3/52BFlX91h9rEhD6wMq9EApKg3X4J2QdAmH3ZVy1yEjsaCu2iJ/+2b05OK NOXx/hFxfoJEOTqQj6awD8B6e3Vm+fZ7Qy2C5ELmMmSP+V/tGijlwpziVZl0R7GBsandi rUyEgVt2ZMQBEATzAz6eOiwiYoHGiR/dXTZkrLliYllLi2dFKfG2gKnthrVSErKyDQE/k 7ikpIgZ0ZdK5SC+KIaSIdF+FKaj6MxCQQAKQd1mle18gcB7ePC41iaqbl9KSoVDMF8Xxu GrckcIsU4CZ4EJ+mGXNy2OHheHPw+ltIdthAL2gRo/vg8NEaCfnRnSMoME7OtQ7POWg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=HrQW+y5Q; arc=none smtp.remote-ip=95.215.58.210 Received: from mta1.migadu.com (out-210.mta1.migadu.com [95.215.58.210]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81DD3606A336 for ; Fri, 13 Nov 2026 07:16:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 81DD3606A336 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=HrQW+y5Q X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=RQ8pA60G+MeCru45VDvMKHyN9yX33rvbO0twB8IXd74=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794554201; v=1; x=1795159001; b=HrQW+y5QO8vDTKAsYV89vMRox6nntGzm8OdLlVtRs/Sid3j/8LzLUG6vyjA2mLzXM5XR2cAp UdK3wBOwwKR5LAYG6akoZsmC4N5sn1/iNhjiy+KzjmytkpqSsqPgRUG8BRwEzpZKIfxVcCmhkDX v4qAncDQRc4nguv+KYghDYAA= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 7f7d0d625172132b; Fri, 13 Nov 2026 07:16:41 +0000 X-Mizu-Trace-ID: 7f7d0d625172132b X-Migadu-Flow: FLOW_OUT From: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , Alexandre Ghiti , WangYuli , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] riscv: kgdb: Fix break size, insn patch and masking Date: Fri, 13 Nov 2026 08:16:11 +0100 Message-ID: <20261113071616.219623-1-clement.leger@linux.dev> X-Mailer: git-send-email 2.55.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This small series fixes a few problems that were spotted with kgdb. First patch is the use of patch_insn_write() to set breakpoints instead of copy_to_kernel_nofault(). This fixes the use of kgdb with CONFIG_STRICT_KERNEL_RWX which maps text as RX. Second patch removes the hardcoded epc += 4 with BREAK_INSTR_SIZE so that it works with CONFIG_RISCV_ISA_C. Last one is more of a correctness fix with respect to jalr instructions. ISA specifies that the target address is computed by masking the LSB to 0. Clément Léger (3): riscv: kgdb: use patch_insn_write() to set breakpoints riscv: kgdb: use BREAK_INSTR_SIZE instead of hardcoded value riscv: kgdb: clear bit 0 of single-step jump targets arch/riscv/kernel/kgdb.c | 39 ++++++++++++++++++++++++++++++++------- 1 file changed, 32 insertions(+), 7 deletions(-) -- Clément Léger From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10388606A8B5 for ; Fri, 13 Nov 2026 07:17:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=pXX8E+g0; dkim=fail reason="signature verification failed" (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=HrQW+y5Q DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Unsubscribe-Post:List-Owner; bh=wa4I9dX9YRKvCbG8DcVPaUF8kMEQq+rR8wBN3sXw1bQ=; b=pXX8E+g0CfecV4yP/r/sx9DHit oQYDrHT5ivOtZrBJECyTyjRZxCk2rskef+DhAdW4DltlvWMHj0vuxNyeCLgGYzlhEywbCgvdaR/Te SJBKd0WU4x4C68RNkPSIapGocZwp9t/JTnF6mgnbqKkWmrarQ36n11Am34vb27go1CJNOIzpPjiny tRiwFmeOr6O98WsUXTj/D68dsv82+TcUZJXl6FqvgjQzIwAx8f9lmx+82nB1jKnuGBHyfZM2WcxsY bAUoFAfN4IKNZ1usZuEwDCS1imKhDD4E5Oe/aZwwoQz1QvDN1Mu7wZ9tz8Jc1HePI9Tu1q+gpDpka BZHPFq9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRlWu-0000000Brsn-2NJe; Fri, 13 Nov 2026 07:17:00 +0000 Received: from out-134.mta0.migadu.com ([2001:41d0:1004:224b::86] helo=mta0.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xRlWg-0000000BrnT-0S6w for linux-riscv@lists.infradead.org; Fri, 13 Nov 2026 07:16:59 +0000 X-Envelope-To: linux-riscv@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=RQ8pA60G+MeCru45VDvMKHyN9yX33rvbO0twB8IXd74=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794554201; v=1; x=1795159001; b=HrQW+y5QO8vDTKAsYV89vMRox6nntGzm8OdLlVtRs/Sid3j/8LzLUG6vyjA2mLzXM5XR2cAp UdK3wBOwwKR5LAYG6akoZsmC4N5sn1/iNhjiy+KzjmytkpqSsqPgRUG8BRwEzpZKIfxVcCmhkDX v4qAncDQRc4nguv+KYghDYAA= X-Envelope-To: linux-riscv@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id 7f7d0d625172132b; Fri, 13 Nov 2026 07:16:41 +0000 X-Mizu-Trace-ID: 7f7d0d625172132b X-Migadu-Flow: FLOW_OUT From: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , Alexandre Ghiti , WangYuli , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] riscv: kgdb: Fix break size, insn patch and masking Date: Fri, 13 Nov 2026 08:16:11 +0100 Message-ID: <20261113071616.219623-1-clement.leger@linux.dev> X-Mailer: git-send-email 2.55.0 X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261112_231646_288717_E1D19850 X-CRM114-Status: UNSURE ( 5.93 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" X-Spam-Status: No, score=-11.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhpcyBzbWFsbCBzZXJpZXMgZml4ZXMgYSBmZXcgcHJvYmxlbXMgdGhhdCB3ZXJlIHNwb3R0ZWQg d2l0aCBrZ2RiLgoKRmlyc3QgcGF0Y2ggaXMgdGhlIHVzZSBvZiBwYXRjaF9pbnNuX3dyaXRlKCkg dG8gc2V0IGJyZWFrcG9pbnRzIGluc3RlYWQKb2YgY29weV90b19rZXJuZWxfbm9mYXVsdCgpLiBU aGlzIGZpeGVzIHRoZSB1c2Ugb2Yga2dkYiB3aXRoCkNPTkZJR19TVFJJQ1RfS0VSTkVMX1JXWCB3 aGljaCBtYXBzIHRleHQgYXMgUlguCgpTZWNvbmQgcGF0Y2ggcmVtb3ZlcyB0aGUgaGFyZGNvZGVk IGVwYyArPSA0IHdpdGggQlJFQUtfSU5TVFJfU0laRSBzbwp0aGF0IGl0IHdvcmtzIHdpdGggQ09O RklHX1JJU0NWX0lTQV9DLgoKTGFzdCBvbmUgaXMgbW9yZSBvZiBhIGNvcnJlY3RuZXNzIGZpeCB3 aXRoIHJlc3BlY3QgdG8gamFsciBpbnN0cnVjdGlvbnMuCklTQSBzcGVjaWZpZXMgdGhhdCB0aGUg dGFyZ2V0IGFkZHJlc3MgaXMgY29tcHV0ZWQgYnkgbWFza2luZyB0aGUgTFNCIHRvCjAuCgpDbMOp bWVudCBMw6lnZXIgKDMpOgogIHJpc2N2OiBrZ2RiOiB1c2UgcGF0Y2hfaW5zbl93cml0ZSgpIHRv IHNldCBicmVha3BvaW50cwogIHJpc2N2OiBrZ2RiOiB1c2UgQlJFQUtfSU5TVFJfU0laRSBpbnN0 ZWFkIG9mIGhhcmRjb2RlZCB2YWx1ZQogIHJpc2N2OiBrZ2RiOiBjbGVhciBiaXQgMCBvZiBzaW5n bGUtc3RlcCBqdW1wIHRhcmdldHMKCiBhcmNoL3Jpc2N2L2tlcm5lbC9rZ2RiLmMgfCAzOSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzMiBp bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKLS0gCkNsw6ltZW50IEzDqWdlcgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFp bGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=