All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Chris Down <chris@chrisdown.name>
Cc: Vlastimil Babka <vbabka@kernel.org>, Harry Yoo <harry@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Hao Li <hao.li@linux.dev>, Christoph Lameter <cl@gentwo.org>,
	David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Marco Elver <elver@google.com>,
	GONG Ruiqi <gongruiqi@huaweicloud.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-mm@kvack.org, linux-hardening@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@meta.com
Subject: Re: [PATCH v2 5/6] mm/slab: Support disabling KMALLOC_PARTITION_CACHES at boot
Date: Fri, 13 Nov 2026 09:54:01 -0800	[thread overview]
Message-ID: <202611130951.3B6741770@keescook> (raw)
In-Reply-To: <20261113005212.556c6f234712bdfe@chrisdown.name>

On Fri, Nov 13, 2026 at 12:52:12AM -0800, Chris Down wrote:
> Kees Cook writes:
> > Swap the ifdef for a CONFIG-controlled static branch that defaults off
> > without CONFIG_KMALLOC_PARTITION_CACHES.
> 
> I've dropped the #ifdef in v3. kmalloc_partition_enabled now defaults to
> IS_ENABLED(CONFIG_KMALLOC_PARTITION_CACHES), and kmalloc_partition= is
> ignored without that option, so new_kmalloc_cache() doesn't need any
> #ifdef.
> 
> I've kept it as a bool rather than a static key, for the same reason as
> on 3/6: the only reader is new_kmalloc_cache(), at boot. When
> partitioning is off, kmalloc_type() still picks a partition index, but
> every one of them resolves to the normal cache. So the flag is never
> read on the allocation path.
> 
> The one place a static key would actually help is kmalloc_type(), where
> it could skip picking a partition and go straight to KMALLOC_NORMAL.
> Since kmalloc_type() is inline, that means exporting the key to modules.
> That seemed like more than this series needs, but if you think it's
> worth it I'm happy to add it.

I'll go look at v3. The goal was both immutability after init and
avoiding a branch in an allocation path.

-- 
Kees Cook

  reply	other threads:[~2026-11-13 17:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  6:07 [PATCH v2 0/6] mm/slab: Support selecting slab hardening features at boot Chris Down
2026-10-29  6:07 ` [PATCH v2 1/6] mm/slab: Enable SLAB_FREELIST_HARDENED by default Chris Down
2026-10-31  4:13   ` Kees Cook
2026-10-29  6:07 ` [PATCH v2 2/6] mm/slab: Enable SLAB_FREELIST_RANDOM " Chris Down
2026-10-31  4:15   ` Kees Cook
2026-11-13  8:51     ` Chris Down
2026-10-29  6:08 ` [PATCH v2 3/6] mm/slab: Support disabling SLAB_BUCKETS at boot Chris Down
2026-10-31  4:17   ` Kees Cook
2026-11-01 18:34     ` Harry Yoo
2026-11-13  8:52       ` Chris Down
2026-11-13  8:51     ` Chris Down
2026-10-29  6:08 ` [PATCH v2 4/6] slub_kunit: Add a test for the slab_buckets boot parameter Chris Down
2026-10-31  4:22   ` Kees Cook
2026-11-13  8:52     ` Chris Down
2026-10-29  6:09 ` [PATCH v2 5/6] mm/slab: Support disabling KMALLOC_PARTITION_CACHES at boot Chris Down
2026-10-31  4:28   ` Kees Cook
2026-11-13  8:52     ` Chris Down
2026-11-13 17:54       ` Kees Cook [this message]
2026-10-29  6:09 ` [PATCH v2 6/6] slub_kunit: Add a test for the kmalloc_partition boot parameter Chris Down
2026-10-31  4:29   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202611130951.3B6741770@keescook \
    --to=kees@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=chris@chrisdown.name \
    --cc=cl@gentwo.org \
    --cc=corbet@lwn.net \
    --cc=elver@google.com \
    --cc=gongruiqi@huaweicloud.com \
    --cc=hao.li@linux.dev \
    --cc=harry@kernel.org \
    --cc=kernel-team@meta.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.