From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794585659; b=oP3Nnhrqt7NIRjsVGUnwTrYDAjlehlIsO+0kB+vjAPTHPWAnjxQ4pUGadwdzjk09Uc0c adVA+2bn7cHKmXaqCzjhViGgW4S55ILIk1qpvicCtx99Qh4PqO5xedoaAr3Vd/pO1rwaN xangeW/pb+Lzy9OYgm4MmRV/uvl4eLm3UK3N5eqRoAK+q2eauOKbyrhi4i5R94igzcFGU PqffuonXfDJMJAMEAoDEgHrCbJ9W/PEfwMrjPR65h1/CsjbABkw2u/B9uxoiuJsK+IXUD BRJHmkdDa9WBeXfEbHeSiDQYljEUNuOtdDvp0lBICGHLBfEOSoppVIPjma8TqYjq3pQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794585659; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=he8TxIB4Hn3NTh2kbtBatenbnACunliV6AzQ2B9MsWo=; b=NmRL/jqcUuKDf1wly5+vMIK7d0uRdaP0uM7GZNJpQn003T6DLf0hGN9AR5IFrSLc3d7y +33OLD350Rqg7QJGaw8o8WhzwkAsGKpIKeMOnfHDj3YsJh3phesTPTdy8y3U+YsYslYO5 +RtGgE2hNvcUlLzZf1Y7mNVdN1UZJ3vHODOSLKOJoJcXRuvtRraBScQEQ7fNc0eTCpZiP S1f4ZmreIsivyp2xRKs2FhO+zoYe09Yw3WfTegD2AL965nB9v8p+B16Co4+fXPdcYiiEI 8qEpeROEE6UZ1Jx/1HbgdhyqpOygKbZZgbzA79aszWjBVkVzFJH+djYA9W27TTnfCRw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=xinjiZ70; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FB64606B2E8; Fri, 13 Nov 2026 16:00:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=xinjiZ70 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDC661F000C5; Fri, 13 Nov 2026 16:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794585659; bh=he8TxIB4Hn3NTh2kbtBatenbnACunliV6AzQ2B9MsWo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=xinjiZ70U/UdYUQIkaMUrxD5qqa6HYOj3XGGvEXoxqRg1pz0xItlUGuPUMYjEBpDK 5XJueBBJ6YVFxwMYBUlwikEwrdoZHVzsmf+w9sZb195TwOes+aN8fyNMXj9N617aYU EYnekPhRi/WWEyttheh31oyrEJdVoNWn2O1a1c8w= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xie Yongji , "chenglong.ma" , "Michael S. Tsirkin" , Sasha Levin , Claude Code Subject: [PATCH 7.3 272/507] vduse: fix VA/PA confusion in the coherent page fault path Date: Fri, 13 Nov 2026 10:49:36 -0500 Message-ID: <20261113153803.931199357@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153753.358973689@linuxfoundation.org> References: <20261113153753.358973689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: chenglong.ma [ Upstream commit bb2e6f166547838fd7c320b01c90918b736f76e2 ] vduse_domain_get_coherent_page() assumes that iotlb entries above bounce_size were installed by vduse_domain_alloc_coherent(), so it treats map->addr as a physical address. But vduse registers with use_va = true, and when the device is bound to vhost_vdpa, vhost_vdpa_va_map() stores a userspace virtual address in map->addr, which vduse_domain_set_map() then copies into the same iotlb. A process holding the domain file descriptor across a rebind can therefore fault in an arbitrary physical page with read/write access, ignoring the entry permissions. Additionally, since the domain file mmap lacks VM_IO, the domain file itself can be mapped and passed to vhost_vdpa_va_map(), producing self-referential entries that bypass the coherent path check. To fix, only translate entries whose backing file is the domain file itself in vduse_domain_get_coherent_page(), reject such entries in vduse_domain_set_map() since only external mappings should be imported, and set VM_IO on the domain file mmap so vhost_vdpa_va_map() refuses to map it in the first place. Fixes: 8c773d53fb7b ("vduse: Implement an MMU-based software IOTLB") Cc: Xie Yongji Cc: stable@vger.kernel.org Reported-by: chenglong.ma Signed-off-by: chenglong.ma Signed-off-by: Michael S. Tsirkin Co-Authored-By: Claude Code Signed-off-by: Sasha Levin --- drivers/vdpa/vdpa_user/iova_domain.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/vdpa_user/iova_domain.c b/drivers/vdpa/vdpa_user/iova_domain.c index b6c958224b7ce..28a977248a0d3 100644 --- a/drivers/vdpa/vdpa_user/iova_domain.c +++ b/drivers/vdpa/vdpa_user/iova_domain.c @@ -76,6 +76,10 @@ int vduse_domain_set_map(struct vduse_iova_domain *domain, for (map = vhost_iotlb_itree_first(iotlb, start, last); map; map = vhost_iotlb_itree_next(map, start, last)) { map_file = (struct vdpa_map_file *)map->opaque; + if (!map_file || map_file->file == domain->file) { + ret = -EINVAL; + goto err; + } ret = vduse_iotlb_add_range(domain, map->start, map->last, map->addr, map->perm, map_file->file, @@ -226,6 +230,7 @@ vduse_domain_get_coherent_page(struct vduse_iova_domain *domain, u64 iova) { u64 start = iova & PAGE_MASK; u64 last = start + PAGE_SIZE - 1; + struct vdpa_map_file *map_file; struct vhost_iotlb_map *map; struct page *page = NULL; @@ -234,6 +239,10 @@ vduse_domain_get_coherent_page(struct vduse_iova_domain *domain, u64 iova) if (!map) goto out; + map_file = (struct vdpa_map_file *)map->opaque; + if (!map_file || map_file->file != domain->file) + goto out; + page = pfn_to_page((map->addr + iova - map->start) >> PAGE_SHIFT); get_page(page); out: @@ -579,7 +588,7 @@ static int vduse_domain_mmap(struct file *file, struct vm_area_struct *vma) { struct vduse_iova_domain *domain = file->private_data; - vm_flags_set(vma, VM_DONTDUMP | VM_DONTEXPAND); + vm_flags_set(vma, VM_IO | VM_DONTDUMP | VM_DONTEXPAND); vma->vm_private_data = domain; vma->vm_ops = &vduse_domain_mmap_ops; -- 2.53.0