From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794585716; b=n0THAbkcFHR8oupnh0pBOswjsQNTikbjfyb2f/BJd9YFhEdE+chtLoGF1m6m/2HTTkex vyM0fLCNrIWFY/obNwvDDoPvAldYXZUA7156UAP58NXsNSs44CGuSbWymtMfPliV+NTlv +FQak69xwhojHMBVywXlhCBC1wmSlzcFJticfQ6TzADL22NXHHzNsg0Q9iIxZGk+lKyWZ Hisu4t40XUJmsvXTERy3FG/GcwW7hmFDodK6v4ERLjlGm9ygKp/eEtA1feLEQdzhDpB48 wxLch60fvAZCVF49fcVGLlboLLUKx9xZd/0dBBgC1Dv/LXlUowYzFs2S48ZvKagaVCw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794585716; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=EtxZXBHIdLkAu02WS3OlVDrysPtUyrcbMLYTzy2rkTQ=; b=OaCaD8t1s+xxJj0l1dQ4rD+bqRdGYGrf2eAm7pPKMw7XbxZGc0YrVFy2+mWusP8N76ka oQbYBFfwPz1vyMdd/Dw4xEtL94n2kM7StyjShDsfoTes8VgzwCubD1oh3NmSg1jv8DSS6 CnmgifILLhONq055LzNCmGjVDq81uCNm3Mk/O7wvbG/BYRmdoB2E6ZDzidKKNhdUikDo0 RONmFQdp/y6X0PQJ7lTL7CstYB5DAiqP8bQ6FTELR635mMe24eS5D7T4EcC7/Ew4INNNF KktkNh7C02/FMkkbn9V1USbMeL8AemV3G2QHPqtch12BkESb0k6TZMAusr8guqYYQwQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=TopVbNkP; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BCDA60A383B; Fri, 13 Nov 2026 16:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=TopVbNkP Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D3E71F000C5; Fri, 13 Nov 2026 16:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794585716; bh=EtxZXBHIdLkAu02WS3OlVDrysPtUyrcbMLYTzy2rkTQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TopVbNkPZAU5DnYAWL66qKHByQ7hwfpNUPt0qiUE5STcX+AVDUcwenIsgopA9jd8q tADJ96oNCUQ1f4cDQPO+2bmYrhuRLIc9YxeftzpFOVfo5cDdVYySot1Ve8XNMEgkNT Pcok7BX7u3qYSfOqdAuE3+tr4a2SzEUknu5595iI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Josef Bacik , "Lorenzo Stoakes (ARM)" , Pedro Falcato , Muhammad Usama Anjum , Lance Yang , "David Hildenbrand (Arm)" , Sasha Levin Subject: [PATCH 7.3 318/507] mm/mremap: fix moving PUD leaves Date: Fri, 13 Nov 2026 10:50:22 -0500 Message-ID: <20261113153806.196059013@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153753.358973689@linuxfoundation.org> References: <20261113153753.358973689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Josef Bacik [ Upstream commit 440c8779757f09f290770b1d361dc1516a9d0b3e ] pud_none_or_clear_bad() only really works on page tables. PUD leaves confuse the check and make us clear the page table entry and print a warning. Since commit aed877c2b4257 ("device/dax: properly refcount device dax pages when mapping"), this also leaks device-DAX folio references, mapcounts and RSS accounting, resulting in "Bad rss-counter state" warnings on exit. Allow PUD leaves in get_old_pud(). If a PUD leaf cannot be moved as a whole or the move fails, split it. This unmaps it with proper accounting instead of treating the leaf entry as a PMD table. Keep using pud_trans_huge() for now, in the future this code should be cleaned up to just check for PUD leaves. Fix generated by an LLM and sent by Josef Bacik in private. Fixes: a00cc7d9dd93 ("mm, x86: add support for PUD-sized transparent hugepages") Cc: stable@vger.kernel.org Signed-off-by: Josef Bacik Reviewed-by: Lorenzo Stoakes (ARM) [ david: fallthrough after splitting ] Reviewed-by: Pedro Falcato Tested-by: Muhammad Usama Anjum Link: https://patch.msgid.link/20261031-fixes_core-v3-32-d6437171ecc3@kernel.org Reviewed-by: Lance Yang Signed-off-by: David Hildenbrand (Arm) Signed-off-by: Sasha Levin --- mm/mremap.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mm/mremap.c b/mm/mremap.c index fd4da262ea13c..b6e0a4206016b 100644 --- a/mm/mremap.c +++ b/mm/mremap.c @@ -87,7 +87,7 @@ static pud_t *get_old_pud(struct mm_struct *mm, unsigned long addr) return NULL; pud = pud_offset(p4d, addr); - if (pud_none_or_clear_bad(pud)) + if (!pud_trans_huge(*pud) && pud_none_or_clear_bad(pud)) return NULL; return pud; @@ -847,11 +847,10 @@ unsigned long move_page_tables(struct pagetable_move_control *pmc) if (!new_pud) break; if (pud_trans_huge(*old_pud)) { - if (extent == HPAGE_PUD_SIZE) { - move_pgt_entry(pmc, HPAGE_PUD, old_pud, new_pud); - /* We ignore and continue on error? */ + if (extent == HPAGE_PUD_SIZE && + move_pgt_entry(pmc, HPAGE_PUD, old_pud, new_pud)) continue; - } + split_huge_pud(pmc->old, old_pud, pmc->old_addr); } else if (IS_ENABLED(CONFIG_HAVE_MOVE_PUD) && extent == PUD_SIZE) { if (move_pgt_entry(pmc, NORMAL_PUD, old_pud, new_pud)) continue; -- 2.53.0