From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794585868; b=E3JeFsNtUSagjoa5HEnVE48sCnScFADBxb4sEIh2M/eBPZW2LMdCTkCBY34lreicoouv ON8f6ViADESkcVuNrAjNJOs7fpixYuBG+DXYEg8hHfT8fp/jEz8n7IcQLmGOoaBhXb240 gdP1fWx6z90Bo0v26wU8xxZ5RduzJ9q1boFGUObbitJqhlOSHDlEwibVJ6wiitZVq62bG EdKEo33knMzOBPc204jMB0gc+GjAnSQKS3hOAiVPzJkPqi4H2DKa6rgMqBdJ3x3uYqn/C CBSqni8gC6Rkc1MTPaWABTx0vGCOkelDuzQ9XTI4G2nrRH0fCU+ZK+qy27JLQwyx7lQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794585868; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=XYQfunAO5YDtK9kLSTDlpVZH2Ps05oLAfnaaeYCGGUI=; b=W5kVzxhhl3e8ETv72JI+3cNx+O/sLB2hSi5o+hqaPX+gQtCsIDAhGU0kgT9wUbojCex8 Q/AZu85Y9poCbAk70n3NLll3VjIif2SkigSuLXDXxECunNlxj5e/J2yD5lrOSMdxJRTIP hrsZaJJyuA/OqZ1kNmm+ZFUsQuCoCXw8QBJQn9TyYC2vawuUwbfI4oZGZuy7YHrzk+Vr1 AOnj+eiFYpLkrahASDQxVz/VzKOISvQZgzfNadUAfTl5YlII1drSoM5HlRFbmCu8zkjoh RMbhg6+qu3V+QusLBR8GigxPkth7PMKUbcaC9gx3BMIiOzVAUp9TrmWRAH3o2emECnA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Wlv2vLNf; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D21C0606EA89; Fri, 13 Nov 2026 16:04:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Wlv2vLNf Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DDF31F000C4; Fri, 13 Nov 2026 16:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794585868; bh=XYQfunAO5YDtK9kLSTDlpVZH2Ps05oLAfnaaeYCGGUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Wlv2vLNfDB0H54Iv/TogKkRm0NGZMCCXfvQ1t7a+NbDT6wGiXfeh6tFeVKMjJzOj4 fJbVa1SBXa5aBh/dLutmWB6ZdXwNOotFQ8mhwz2t9w7Gu7bYJN7QuOTDCgjuMUwASf /i+WFoylt8aOSsi871M6XHYA1WkbcLWRev7q8CIQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jan Kara , Matthias Goergens , Sasha Levin Subject: [PATCH 7.3 414/507] udf: fix preallocation discarding before an empty allocation extent Date: Fri, 13 Nov 2026 10:51:58 -0500 Message-ID: <20261113153810.763601025@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153753.358973689@linuxfoundation.org> References: <20261113153753.358973689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Matthias Goergens [ Upstream commit 0c52750caaaccee8b0e929450fe6538ec4985722 ] udf_discard_prealloc() finds the last extent of a file by peeking at the next one with udf_next_aext() and stopping when that returns 0. The peek reads into eloc and elen, and the code then uses them as the last extent. But when udf_next_aext() returns 0 they hold no defined value: if the extent list ends in a continuation descriptor that leads to an empty allocation extent, they describe that continuation, i.e. the block of the empty allocation extent, one block long. The kernel creates such lists itself: when udf_delete_aext() removes the only descriptor of the last allocation extent in a list, it leaves that allocation extent empty and the continuation to it in place. If the last extent is a preallocation, udf_discard_prealloc() deletes it with udf_delete_aext(), which finds the following allocation extent empty, so it also removes the continuation and frees that allocation extent's block. udf_discard_prealloc() then frees eloc and elen: that block a second time, instead of the preallocated blocks. On a space bitmap the preallocated blocks leak and the free block count drifts. On an unallocated space table the second free adds a second free extent for the same block, which is later handed out twice: fsx as run by generic/091 and generic/263 ends up with two parts of its test file in one block and reads back bad data. Peek into separate variables, so that eloc and elen keep the last extent that udf_next_aext() returned with 1. Fixes: cfe4c1b25dd6 ("udf: Fix preallocation discarding at indirect extent boundary") Cc: stable@vger.kernel.org Suggested-by: Jan Kara Signed-off-by: Matthias Goergens Link: https://patch.msgid.link/480eccd1264a4cea5226fc36ed108931b2c403fb.1793349907.git.matthias.goergens@gmail.com Signed-off-by: Jan Kara Signed-off-by: Sasha Levin --- fs/udf/truncate.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/fs/udf/truncate.c b/fs/udf/truncate.c index 0990f94b85518..75151a59f0da6 100644 --- a/fs/udf/truncate.c +++ b/fs/udf/truncate.c @@ -124,8 +124,8 @@ void udf_discard_prealloc(struct inode *inode) { struct extent_position epos = {}; struct extent_position prev_epos = {}; - struct kernel_lb_addr eloc; - uint32_t elen; + struct kernel_lb_addr eloc, tmpeloc; + uint32_t elen, tmpelen; uint64_t lbcount = 0; int8_t etype = -1; struct udf_inode_info *iinfo = UDF_I(inode); @@ -141,7 +141,8 @@ void udf_discard_prealloc(struct inode *inode) /* Find the last extent in the file */ while (1) { - ret = udf_next_aext(inode, &epos, &eloc, &elen, &tmpetype, 0); + ret = udf_next_aext(inode, &epos, &tmpeloc, &tmpelen, + &tmpetype, 0); if (ret < 0) goto out; if (ret == 0) -- 2.53.0