From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794585856; b=gBFA//1l2FmuCbs7cbiiUkxF0u+RS+EayeNFEg9tUD7virgVObPrLhTgV4sZO369Vn+L z1Xh93T4bIR7VXG/mT0pdsMClS4Rnv6oJOC0uIIrwy9ndG3Xta3vBGsuwT2VFYTrGsRWP NzzyGmbZS/7lMwoQpX4zShSHTjf8anLyLReHjV+MEL3XDCKiG3oBMrGE4FM1SYWj01cIe O919WjlhWUdyZFCQNgY6NDvQycMbl38Fz/iEbdGEA7T04/O2xB+h8tNxrY8vZzKX6lUor oudmvX/JG+C50Sh/Juo86d+gzW6fQuULiD3EKqERdJVMVFSdINNjLJTJFyzNcAzrb/w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794585856; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=Y+qDGIWYp6AwC+a5vPfK1MllZHkilWBYAtJ+JgJANIU=; b=ghl9V/I03c/DD0MO8cpHH0FCj+T8i5uTJBJX+jDYLZg2MSvJZ6nZfXMJgEA649aLeSRF V+oHhoxyu5BoZ5Vt0AbfWKepnSzlONcCBf1qreD7N4HSq/P05P3wTDmFVhvCuhhONYDZq z2yg3jMnhtPjtq418f3P/7nbY7TIReIDgf+3m36fuIHnt3zSs7kVL1bGnECbyl/ri7HCc aImnIeB3X2D63It3a5vJPwkR2TgbJHd61Rb3lOAfFtg0eJNCn7v9oJlSh+nUlIY4CfZt8 ymM24aCPNVn0n/ZcTjY1HZmxDy4klM2wfQdUnfdb7b78i1+HSp/FtiLQZetVy+Zu8Nw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=BOLuC3X5; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63E90606A88A; Fri, 13 Nov 2026 16:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=BOLuC3X5 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FEEC1F000C5; Fri, 13 Nov 2026 16:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794585856; bh=Y+qDGIWYp6AwC+a5vPfK1MllZHkilWBYAtJ+JgJANIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BOLuC3X5fkKGizqzfnhHr7Uv6c3qHcAkw63+XyrUC2Bk0XdLMYVuZt1S4IrXSrPus 0NiVQ0xEeGBr5qDWgyQqSXolsWQ7hvEE/XBdy7dgyhjXY6bjE/6JQq3xyhI5JHYrP/ APZNFXFx3T92ovtRLzL5faAolo77s67AYy32eZmI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kyrylo Biryuk , Marco Ziliani , Niklas Cassel , Sasha Levin Subject: [PATCH 7.3 431/507] ata: libata-pmp: disable the SEMB port on Marvell 88SM9705 Date: Fri, 13 Nov 2026 10:52:15 -0500 Message-ID: <20261113153811.353485114@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153753.358973689@linuxfoundation.org> References: <20261113153753.358973689@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.3-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marco Ziliani [ Upstream commit 6b67cdb463b006e57f15e3fe4ea03b00f0ac9ee5 ] The Marvell 88SM9705 is a 1-to-5 SATA port multiplier with one additional SEMB (SATA Enclosure Management Bridge) port [1]. Ports 0-4 are device ports and port 5 is the SEMB. The number of fan-out ports in GSCR[2] is 6 when the SEMB is enabled and 5 when it is not, so on boards without the SEMB there is no link 5 and this quirk does nothing. That includes the common 8-port PCIe cards that pair an 88SE9215 with an 88SM9705, which report 5 ports. The SEMB port never answers SRST. libata probes it like a device port, and every EH round on the PMP ends in a retry loop that lasts about a minute before EH gives up, then starts over: ata19.15: Port Multiplier 1.2, 0x1b4b:0x9705 r160, 6 ports, feat 0x1/0x1f ata19.05: hard resetting link ata19.05: failed to resume link (SControl 0) ata19.05: softreset failed (1st FIS failed) ata19.05: hard resetting link ... ata20.05: reset failed, giving up Disk discovery waits for this, including disks on other controllers. libata.force only partly works around it. The "disable" horkage only takes effect after IDENTIFY, which the SEMB link never reaches. "norst" on port 5 stops the retry loop, but the disks still come up about a minute later than with this change (see below). Treat port 5 the same way as port 4 of the Marvell 88SM4140 and mark the link ATA_LFLAG_DISABLED. Tested on a Synology DX1222 expansion unit (four 88SM9705 r160 behind a Marvell 88SE9235, passed through to a KVM guest, 6 disks), 7.4-rc1 with and without this change, one boot each: softreset reset failed, last disk failed giving up attached 7.4-rc1, no libata.force 60 12 197 s 7.4-rc1, libata.force=N.05:norst 0 0 70 s 7.4-rc1 + this patch, no force 0 0 11 s The problem was first found on a Synology DX1215 with the same chain, where this change brought the disks up after about 20 s instead of about 200 s, including a disk on a separate AHCI controller. Each PMP still logs one "failed to resume link (SControl 0)" for port 5 at probe time. Link: https://www.marvell.com/content/dam/marvell/en/public-collateral/storage/marvell-storage-88sm9705-functional-specifications-2015-06.pdf [1] Cc: stable@vger.kernel.org Tested-by: Kyrylo Biryuk Signed-off-by: Marco Ziliani Link: https://lore.kernel.org/r/20261107-pmp-88sm9705-v2-1-18eed983d3db@gmail.com Signed-off-by: Niklas Cassel Signed-off-by: Sasha Levin --- drivers/ata/libata-pmp.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index 904f418387d11..43991e54eb081 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c @@ -482,6 +482,20 @@ static void sata_pmp_quirks(struct ata_port *ap) if (link->pmp == 4) link->flags |= ATA_LFLAG_DISABLED; } + } else if (vendor == 0x1b4b && devid == 0x9705) { + /* + * Marvell 88SM9705 quirks + * + * 1-to-5 PMP with an extra SEMB port. It reports 6 ports and + * port 5 is the SEMB, which never answers SRST: EH spends about + * a minute per round retrying it, and disk discovery waits for + * that. Seen behind a Marvell 88SE9235 in the Synology DX1215 + * and DX1222. + */ + ata_for_each_link(link, ap, EDGE) { + if (link->pmp == 5) + link->flags |= ATA_LFLAG_DISABLED; + } } } -- 2.53.0