From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794591414; b=WNYeXQ2JxF5FwBqjXSbPNbbL5AaYiZe5PmupD/nrpwR5tLeFyQ6jcF6tcQw8CLoH/tt2 tLl7Vl1IA0RH5ppJkrW812iTruQIlRMVEhez9OjFO8jha2AlXseuFpk++b8sPW6mQrBNt DShi0dtc4kyqZYobtz+wMI5tjux/vvk6x0x+dkIetbBLCwJzESz8y1+4fkXSsTdeNliWz kSVivsHfhk53xMJesfqGcv+tuw4yg4JqYcnGh8VAdViPCARjYP/2+qbA9qs7bwrScvI0z TNav3oQrtEl2JMRqvzaHnkRXbJAxM9rruRLwyVvLJDGjjK7M3Y9FOfqo9MEjTBzRZMA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794591414; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=vgc8OIavxEfWKqeeLPVPKY6TuLWYQq5d1aLUPRHzqoU=; b=hJ8Z6vkqKh1pKdZlM60GQ7qHE19Cu49QFGzfbdqDNqMHCjWhsbvW9wiQlzEHLt8hnfag 9GY+vK0qXW30wqFAVqf1tpoxeiczZzQmu3U2nYh3xH97fGzLdZK+VrxsvvYfzuWLrR/ba XL3amMrVEft8SQNMbqB92PrjipgiAJU/rnthzdMnHz86y8RCFdYtudy21TCndyFBLrziC DRsT7l3Ox4+Yy/4T5EXYZuCwV+UbD35JIVGaH4/lbZoy0nN9GcO/UGNjgobwyn4T0SPKa pIlF8QqDzm/9pMXQiXtwY8PcP5boZg63I1Hqi/q1TaTiS3toTmwEcOYHi3MyiiP3phg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=CWlLaJie; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEBD9607A5D1; Fri, 13 Nov 2026 17:36:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=CWlLaJie Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98C4D1F000C5; Fri, 13 Nov 2026 17:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1794591413; bh=vgc8OIavxEfWKqeeLPVPKY6TuLWYQq5d1aLUPRHzqoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CWlLaJiezHYatY5Ow8hAHAkKkoKvv4lVIDKMEE2FjDNRgtRWU0n14E1sr6Jo5kFxE UNabAyLWwK7oulCoTwpTimibNEl3LfyMi5ONZKAjieQ1GbaeBxLkJlMEExfsmAlTxs FqINIe9mC23vVYyxwJ1GuWirJMjTUetW7gNxfdOs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Tom Verdonck , Guenter Roeck , Sasha Levin Subject: [PATCH 6.12 508/670] hwmon: (tmp108) Fix jiffies wraparound in conversion-ready check Date: Fri, 13 Nov 2026 10:51:12 -0500 Message-ID: <20261113153829.164238052@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261113153811.177190860@linuxfoundation.org> References: <20261113153811.177190860@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tom Verdonck [ Upstream commit 6b8b1d1d7bc7e579b53fc7c3293b787d68de702a ] tmp108 records a one-shot deadline in ->ready_time at probe (and resume) and, on every temperature read, refuses the read with -EAGAIN while time_before(jiffies, ready_time) is true, in order to skip the initial conversion. ->ready_time is an unsigned long compared with time_before(), whose signed difference is only meaningful while the two values are within LONG_MAX jiffies of each other. Because ->ready_time is set once and never refreshed, jiffies keeps advancing away from it, and after 2^31 jiffies the difference flips sign. On a 32-bit HZ=100 kernel that happens ~248.5 days after boot: time_before() then permanently reports "not ready" and the driver returns -EAGAIN on every read, without ever touching the sensor, until the next reboot. The continuous-mode path, which sets ->ready_time to jiffies with no added conversion delay, wraps the same way. Store the deadline as a 64-bit jiffies value and compare it with get_jiffies_64()/time_before64(), which does not wrap in any practical uptime. Fixes: 66e1c9171339 ("hwmon: Add Texas Instruments TMP108 temperature sensor driver.") Cc: stable@vger.kernel.org Signed-off-by: Tom Verdonck Link: https://patch.msgid.link/525fa49d8c50922344fa53e22be5e6133c9bbb62.1790358356.git.tom.verdonck@inspiral.be Signed-off-by: Guenter Roeck [ sashal: adjusted structure context because the params member is absent ] Signed-off-by: Sasha Levin --- drivers/hwmon/tmp108.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.c index a82bbc959eb15..18e7c9d9bcbb8 100644 --- a/drivers/hwmon/tmp108.c +++ b/drivers/hwmon/tmp108.c @@ -73,7 +73,7 @@ struct tmp108 { struct regmap *regmap; u16 orig_config; - unsigned long ready_time; + u64 ready_time; }; /* convert 12-bit TMP108 register value to milliCelsius */ @@ -124,7 +124,7 @@ static int tmp108_read(struct device *dev, enum hwmon_sensor_types type, switch (attr) { case hwmon_temp_input: /* Is it too early to return a conversion ? */ - if (time_before(jiffies, tmp108->ready_time)) { + if (time_before64(get_jiffies_64(), tmp108->ready_time)) { dev_dbg(dev, "%s: Conversion not ready yet..\n", __func__); return -EAGAIN; @@ -371,7 +371,7 @@ static int tmp108_probe(struct i2c_client *client) return err; } - tmp108->ready_time = jiffies; + tmp108->ready_time = get_jiffies_64(); if ((tmp108->orig_config & TMP108_CONF_MODE_MASK) == TMP108_MODE_SHUTDOWN) tmp108->ready_time += @@ -405,7 +405,7 @@ static int tmp108_resume(struct device *dev) err = regmap_update_bits(tmp108->regmap, TMP108_REG_CONF, TMP108_CONF_MODE_MASK, TMP108_MODE_CONTINUOUS); - tmp108->ready_time = jiffies + + tmp108->ready_time = get_jiffies_64() + msecs_to_jiffies(TMP108_CONVERSION_TIME_MS); return err; } -- 2.53.0