From: Simon Horman <horms@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: David Heidelberg <david@ixit.cz>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@kernel.org>,
oe-linux-nfc@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sdf.kernel@gmail.com,
kernel-team@meta.com
Subject: Re: [PATCH RESEND v2 1/2] nfc: llcp: widen getsockopt value locals to u32
Date: Fri, 13 Nov 2026 17:39:07 +0000 [thread overview]
Message-ID: <20261113173907.GY18859@horms.kernel.org> (raw)
In-Reply-To: <20261109-getsockopt_phase3-v2-1-d0f74c6e0f37@debian.org>
On Mon, Nov 09, 2026 at 05:50:37AM -0800, Breno Leitao wrote:
> nfc_llcp_getsockopt() returns each option as a u32 (written through a
> (u32 __user *) cast), but the temporary variables are smaller than that,
> and they are promoted at write side, example:
>
> u8 rw;
> put_user(rw, (u32 __user *) optval)
>
> That is fine, but I want to widen the rw/miux/remote_miu locals from
> u8/u16 to u32 so the following getsockopt_iter conversion can pass their
> address to copy_to_iter(), which expects an object of the exact width.
>
> No functional change.
>
> PS: I am sending this as a separated patch to make sure this conversion
> explicitly reviewable.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-11-13 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 13:50 [PATCH RESEND v2 0/2] nfc: llcp: Move to .getsockopt_iter Breno Leitao
2026-11-09 13:50 ` [PATCH RESEND v2 1/2] nfc: llcp: widen getsockopt value locals to u32 Breno Leitao
2026-11-13 17:39 ` Simon Horman [this message]
2026-11-09 13:50 ` [PATCH RESEND v2 2/2] nfc: llcp: convert to getsockopt_iter Breno Leitao
2026-11-13 17:39 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113173907.GY18859@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=david@ixit.cz \
--cc=edumazet@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-linux-nfc@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=sdf.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.