Re: [PATCH net-next v2 2/9] net: sparx5/lan969x: free the FDMA buffers on init errors and deinit

[Jakub Kicinski <kuba@kernel.org>]

On Fri, 13 Nov 2026 08:59:46 +0100 Daniel Machon wrote:
> > Would it work to set rx->page[fdma->dcb_index][fdma->db_index] = NULL
> > after page_pool_recycle_direct()? The poll loop would also need to
> > consume or refill that DB, or reuse the page in place, instead of
> > recycling the page while the DB still references it.  
> 
> I believe this issue is being addressed on net by Zhang Hewei [1]. I asked for
> changes on v3, but no response so far, so I see three options:
> 
>   1) Wait for Zhang to eventually post a v4.
>   2) Send a follow-up fix for this, in case Zhang does not.
>   3) Incorporate the fix in v3 of this series.
> 
> Either of these works for me, but as I dont know if a v4 is ever sent and how
> many respins that fix will require, it'll probably be fastest for me with 2) or
> 3)
> 
> BTW. The high severity issues on patch #6 and #9 have the same root cause as
> this. So my response to those are the same as this.
> 
> [1] https://lore.kernel.org/netdev/tencent_6BAC076E552C6F338052FC02794D9B28ED0A@qq.com/
> [2] https://lore.kernel.org/netdev/20261110105239.5olhrlwa3mck74f4@DEN-DL-M70577/

Looks like the author respun twice since your response.
Let's wait for the fixes to make it to net-next, v5 conflicts with 
the changes you are making. Don't hesitate to post your own version
of the fixes if you prefer. I'd bet it's an LLM jokey blindly feeding
sashiko pre-existing issue reports into an LLM.
-- 
pw-bot: defer