From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Martin Willi <martin@strongswan.org>,
Antonio Quartulli <antonio@mandelbit.com>
Subject: Re: [PATCH] lib/crypto: x86/chacha: Drop redundant moves from AVX2 code
Date: Fri, 13 Nov 2026 20:24:35 -0800 [thread overview]
Message-ID: <20261114042435.GD2025@sol> (raw)
In-Reply-To: <20261111223455.89467-1-ebiggers@kernel.org>
On Wed, Nov 11, 2026 at 02:34:55PM -0800, Eric Biggers wrote:
> The AVX2 optimized ChaCha code has many instances of moving one register
> to another, then left-shifting the destination register with 'vpslld'.
> This pattern likely was copied from the SSSE3 code, which uses 'pslld'.
> However, like all the other AVX instructions, 'vpslld' has separate
> source and destination registers. Just utilize that instead.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> lib/crypto/x86/chacha-avx2-x86_64.S | 36 ++++++++++-------------------
> 1 file changed, 12 insertions(+), 24 deletions(-)
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next
- Eric
prev parent reply other threads:[~2026-11-14 4:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 22:34 [PATCH] lib/crypto: x86/chacha: Drop redundant moves from AVX2 code Eric Biggers
2026-11-11 23:37 ` Antonio Quartulli
2026-11-14 4:24 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261114042435.GD2025@sol \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=antonio@mandelbit.com \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=martin@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.