From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Antonio Quartulli <antonio@mandelbit.com>,
Martin Willi <martin@strongswan.org>
Subject: Re: [PATCH v2] lib/crypto: x86/chacha: Fix mistakes and inconsistencies in comments
Date: Fri, 13 Nov 2026 20:24:59 -0800 [thread overview]
Message-ID: <20261114042459.GE2025@sol> (raw)
In-Reply-To: <20261113031340.63688-1-ebiggers@kernel.org>
On Thu, Nov 12, 2026 at 07:13:40PM -0800, Eric Biggers wrote:
> Fix various mistakes in comments, many probably originating from
> copy+pasting: incorrect block ranges, duplicate words, and stray text.
>
> Also make chacha_1to4blocks_ssse3() refer to the state matrix using flat
> indexing, like the equivalent AVX2 and AVX512 functions. It was the
> only place using 2D row-column indexing of the state matrix.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> v2: Fixed another inconsistency pointed out by Antonio
>
> lib/crypto/x86/chacha-avx2-x86_64.S | 12 ++++-----
> lib/crypto/x86/chacha-avx512-x86_64.S | 10 ++++----
> lib/crypto/x86/chacha-ssse3-x86_64.S | 36 +++++++++++++--------------
> 3 files changed, 29 insertions(+), 29 deletions(-)
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next
- Eric
prev parent reply other threads:[~2026-11-14 4:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:13 [PATCH v2] lib/crypto: x86/chacha: Fix mistakes and inconsistencies in comments Eric Biggers
2026-11-13 9:30 ` Antonio Quartulli
2026-11-14 4:24 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261114042459.GE2025@sol \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=antonio@mandelbit.com \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=martin@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.