From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794639610; b=g7wFFO9HITsBSrKzY66lW6Eoa4nKz15Ghj/YL6MiwTBFnIdz1V4UKLXQcFdZstk9BdDO 3K78AoZf8FyLdn957DirdUH+ucCYqmvUEmV2w7GwMbMPYCZfsITUMPl2MAqPUzCQ4rZAk x2flIetfLeXRECxWtEdaRgutMShtrPZqMWC2FCdfiUOOeG34i4zM02xFMjtldoDj8siFp 29Cc9CvOHpVay+LCFQF06xsJLYuqbfAPStpHk7ARBuLUNhjjK7M5uYJ2MJRr8WpAoMfCq oTpvnevmS61e3YTrE3I3gT98HrNzecjnjn/IbMArbQLHdoHuROWN0sJXARMfZVhojqQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794639610; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=4gTG38WsX9zlfwv1ra8G0z0EjIfzcI4ZN3JaVMDKU1s=; b=I4bE1cDuI81SO2+rTq57vLp2Y4wFAj6mmj8P1R5wWIVRxhCqDRyko9n2dHjPqqPUS54n 18TkC6RAHxjjpPe8BKJO1/xVbb5CIZNxftV15dGFvXWhJuuCvxOb7zWUGFZRof57Rth5o PKQcFQui2wHdL/1WArbiHGkA1JFBshNvar1wyVprOwYfNWPM7M+YJGunX9ehbzGoe/+cl +c5aaljw46UWpzp1dNYdkxp/Y10/WdQztz6xhNqyblBQFiFvsfGbTkvDqfK5L/p0C6El+ ugWVTHYOQG+kWKNdFLVMecjyfVfwDEuqUtgkN+vD406FxvTQeORBLP9Aa/VinC+27Zg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aoBU5KN7; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6229F606A883 for ; Sat, 14 Nov 2026 07:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=aoBU5KN7 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76AC21F000C5; Sat, 14 Nov 2026 07:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794639610; bh=4gTG38WsX9zlfwv1ra8G0z0EjIfzcI4ZN3JaVMDKU1s=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aoBU5KN7kvmZ/5FLHVNgPzvmDRCAk33DIaFYUG+jH/A0k4UH89ds+44vl1+AeZ3MH bhIdFCS71rrjL/aASoYBwE+W2w6pROgAvnJqehZCnh2/FTHXYh6krExlgIlhLR8px6 KeyBJG4pQXijTgx6AqPDjH4aAfWQz8siLn0lyz6OqGIKcjhX3/pZkgO7cewlV+XEOs QtB0sOqKcd710IeFs94zhFkNDoxfaiRFLUuDIqW0ukihSYbJblI/knTB/qnhDFaLT4 /mncdWC1O6GvJtj09KCXURn53fWYXvOYLJihfn2I2FaoY7QWnrhi/Fe3VvUNzV15No b0T0T2joT0zJg== From: Sasha Levin To: stable@vger.kernel.org Cc: Joseph Qi , Andrew Morton , Heming Zhao , Mark Fasheh , Joel Becker , Sasha Levin Subject: [PATCH 5.10.y 2/2] ocfs2: do not read the entry array of an empty xattr bucket Date: Sat, 14 Nov 2026 02:00:07 -0500 Message-ID: <20261114065844.3237456-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261114065844.3237456-1-sashal@kernel.org> References: <20261109202706-failed-5.10-e8de099f2958@kernel.org> <20261114065844.3237456-1-sashal@kernel.org> X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Joseph Qi [ Upstream commit e8de099f2958c84aa23186c5481e69f7ffd39355 ] ocfs2_check_xattr_bucket_collision() decides whether splitting a bucket can make room by comparing the hash being inserted against the first and the last entry. xh_count comes off disk and is never checked, and a bucket is allowed to hold no entries: ocfs2_xa_remove_entry() keeps the last slot when it removes the only one, so that an empty bucket still carries the hash it is keyed by. xh_count then reads back as 0 while xh_entries[0] is still meaningful, and the second comparison indexes xh_entries[-1]. That is outside the __counted_by_le(xh_count) bounds of xh_entries[] and lands on the header. An entry is 16 bytes and xe_name_hash is its first field, so the value read is xh_count | xh_free_start << 16. It stays inside the block, but the answer is arbitrary, and for an empty bucket it says there is no collision, so a new bucket gets added on the strength of it. An empty bucket holds no entries to collide with. Return before reading the array. One way to reach the test with an empty bucket is a set that removes the bucket's only entry during cleanup and then fails for space again, since it is that second -ENOSPC which calls this. Growing a value past OCFS2_XATTR_INLINE_SIZE is the easy route: the cluster allocation fails, the "!orig_clusters" arm of ocfs2_xa_cleanup_value_truncate() removes the entry, and although the "growing" caller does set ctxt->set_abort, only ocfs2_xattr_block_set() and __ocfs2_xattr_set_handle() look at it, so ocfs2_xattr_set_entry_index_block() goes straight on to the collision check. This sits on commit a9ea8b397864 ("ocfs2: use the stored hash when checking xattr bucket collision"), which gave the collision check its two argument form and is marked for 6.2 and later. The read fixed here is present in the three argument version too, but a tree without that commit needs the hunk adapted by hand. Link: https://lore.kernel.org/20261024151012.1059683-5-joseph.qi@linux.alibaba.com Fixes: 012255961c9e ("ocfs2: Enable xattr set in index btree") Signed-off-by: Joseph Qi Signed-off-by: Andrew Morton Cc: Heming Zhao Cc: Mark Fasheh Cc: Joel Becker Cc: Signed-off-by: Sasha Levin --- fs/ocfs2/xattr.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 35fab516b86ff..52419b31b21af 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c @@ -5611,11 +5611,20 @@ static int ocfs2_check_xattr_bucket_collision(struct ocfs2_xattr_bucket *bucket, u32 name_hash) { struct ocfs2_xattr_header *xh = bucket_xh(bucket); + u16 count = le16_to_cpu(xh->xh_count); + + /* + * An empty bucket keeps the hash of the entry that was removed in + * xh_entries[0] so that it can still be found, but it holds no + * entries to collide with. + */ + if (!count) + return 0; if (name_hash != le32_to_cpu(xh->xh_entries[0].xe_name_hash)) return 0; - if (xh->xh_entries[le16_to_cpu(xh->xh_count) - 1].xe_name_hash == + if (xh->xh_entries[count - 1].xe_name_hash == xh->xh_entries[0].xe_name_hash) { mlog(ML_ERROR, "Too much hash collision in xattr bucket %llu, " "hash = %u\n", -- 2.53.0