All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [gourryinverse:scratch/gourry/managed_nodes/n_memory_features 38/58] mm/page_alloc.c:4804 check_retry_private() warn: bitwise AND condition is false here
Date: Sat, 14 Nov 2026 12:18:34 +0100	[thread overview]
Message-ID: <202611141203.DgUJcomz-lkp@intel.com> (raw)

Unfiltered warning: this smatch report is sent as-is and has not been
reviewed for false positives, so please treat it with due skepticism.

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: Gregory Price <gourry@gourry.net>
TO: "Gregory Price (Meta)" <gourry@gourry.net>

tree:   https://github.com/gourryinverse/linux scratch/gourry/managed_nodes/n_memory_features
head:   82ebacf36393992b1a30dcbf1826f73f6bc34f1d
commit: 61ca25fef1e1cd792c1fd8328734121c5347afd0 [38/58] mm/page_alloc: return to common zonelists when relaxing a mask
:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago
config: mips-randconfig-2200-20261114 (https://download.01.org/0day-ci/archive/20261114/202611141203.DgUJcomz-lkp@intel.com/config)
compiler: mips64-linux-gcc (GCC) 15.3.0
smatch: v0.5.0-9187-g5189e3fb

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202611141203.DgUJcomz-lkp@intel.com/

smatch warnings:
mm/page_alloc.c:4804 check_retry_private() warn: bitwise AND condition is false here

vim +4804 mm/page_alloc.c

902b62810a57ba Vlastimil Babka      2017-07-06  4793  
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4794) /*
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4795)  * A private request stays strict while its zonelist holds an allowed node.
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4796)  * Recheck the cpuset and zonelist cookies before relaxing it to common memory.
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4797)  */
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4798) static bool check_retry_private(gfp_t gfp, int cpuset_mems_cookie,
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4799) 				unsigned int zonelist_iter_cookie,
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4800) 				struct alloc_context *ac)
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4801) {
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4802) 	/* A strict local private request keeps its allocation domain. */
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4803) 	bool policy_valid = ((gfp & __GFP_THISNODE) &&
61ca25fef1e1cd Gregory Price (Meta  2026-10-13 @4804) 			     (ac->alloc_flags & ALLOC_ZONELIST_PRIVATE)) ||
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4805) 			    alloc_policy_valid(ac);
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4806) 
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4807) 	if (read_mems_allowed_retry(cpuset_mems_cookie) ||
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4808) 	    check_retry_zonelist(zonelist_iter_cookie))
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4809) 		return true;
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4810) 	if (policy_valid)
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4811) 		return false;
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4812) 
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4813) 	ac->nodemask = NULL;
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4814) 	ac->alloc_flags &= ~ALLOC_ZONELIST_PRIVATE;
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4815) 	ac->zonelist = node_zonelist(ac->preferred_nid, gfp);
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4816) 	return true;
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4817) }
61ca25fef1e1cd Gregory Price (Meta  2026-10-13  4818) 

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-11-14 11:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202611141203.DgUJcomz-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.