From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.45 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794697720; b=hmd0ed9Kv+Vrd5AheRhoOsFad809IED8Gz1I4RpeXC+Sf8lEVFngmWtJgd1bxcxijGqX RCXnRkpLHkQNHTScmbnv0FqGDE2D/gYTxnQk6/4pTQ41HRBiaELDoutX/Vgt8FjRrW/kA qwJ3njOmgduxsW+tif/yh1r1qWYRoFJFV2/ntqoy7k0uLTcJEBcXe4kEDJhoErWT/fgE0 NrC11LN6XaE2K6VmYkoP9mOOsACBEkR1XeGJWy9nfSZdEOMkc5lVngKbpOxggGoUx4S4X /fvoqgjzEi+afSrRwsIBp5UQp4FYHnd5PHItgFM/fZy2ZeTKRPTcNS8uuoHJ/g+IGgg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794697720; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=6gQE3IU+t2cIqdtVZhrTpEEYl5O5vhKOK1Q7R6X/tsg=; b=scfEZVrjfwL4zgEgauTQdAXsfQClvHNSGAENwwHDLmPp/O4rVDh6H0l57+S43PnMXcGA AakvXurb6imo+7rdLmjD6/jlwuc25bPG6JJ8vwheRhe4d91AQjqr9d4xZDfAGVR6e+Ig1 shd8vpn4mKANr+Cwx64/W5fwS+hEGNup2oczZ/EoaGah61VNBDG7qTR4OzqBj1fBimrzt s/mhnBj1dKLRTVE/t6uj0rptkk0lRZN1+iOQ8H4NBKYwsgQF9O7IHusnZjVZSWYYjiFfS jEmSIJIFx6ncXHkFfR3UMn+xr2rokZ/7zl5cm3w21Nmbq3AhjLUdt2a3ooJKPOC1pbQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=DzSqjZd2; arc=none smtp.remote-ip=209.85.128.45 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E80E60A263B for ; Sat, 14 Nov 2026 23:08:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2E80E60A263B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=DzSqjZd2 Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4a2072b9832so17984635e9.1 for ; Sat, 14 Nov 2026 15:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794697719; x=1795302519; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6gQE3IU+t2cIqdtVZhrTpEEYl5O5vhKOK1Q7R6X/tsg=; b=DzSqjZd223Xa2elVAQbBkL6ejqVgE4nK5Yshf20ooHKziJQK2mgAEAXDKFgmVWyiSO nvKfNG6QmenzeaFXtWwoRLOAaH9ZcSxrlIAwL8mkpCirGe2nAx3S7j0x9qHIY8iv93o1 udRKrfiuqFz7gRZ4sSRBLO382WKomnZYUdKJv7cpxeec3qzeQjF+vE8TP9VC81m0w0kn 2OocJCXx2gFPpO3GS5le07hQKTb3fpdDiOO659DvFBekV3WFLiJ6x/ywAgBxzaGHB9dE rfINzOwENIrjTD/n8Jtc1ev1zXxRmQmhqX91w+Fj0XAi7H7sgTXrMEz1XR9KeKjaDQor DINQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794697719; x=1795302519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6gQE3IU+t2cIqdtVZhrTpEEYl5O5vhKOK1Q7R6X/tsg=; b=t6SpQIP7Ahh4t8odxNmZ/ripgGL3k1X0EDsk0ADDSaz5hxJqQw27zgECRG0ViQZK3G F0jBTTmvKYpRH4C9qBil5clTKaZwla+BjWxPBz/bmDcc1EQoJ7lGvKhIMjlERNNLE4s1 EbXD5mGdIWQxvvetEOsNPwN9eC6aAZMiF/G0ngo/Tvt6TCSpUPHKnlO9syYwCBjTJYvj vV+P27VKIu+o/I8D3gKbn67/JSNW0MMmkGPvfoMKQq0oHNxDQDpVm8yxsxJ0K3kz8XOa /Qo2CQI0+TgqUw5XohoeXICqmJ3bEQw4R7Fs6zPfSDEegN7S1fDOB+aDKy1iacu6FpXf J5bg== X-Forwarded-Encrypted: i=1; AL+hErE8fn/mTNCglQ3vMTPodeAlhtO2zWmzfmLx7n00VnX4Lj4cEc4HwVTD8390I+jR9UwDhTMCELKQugIB@vger.kernel.org X-Gm-Message-State: APuU4Z+Q2Gq1Il9QfkI7t6q4Z5cfsesJmlEG2pEgvEMy84axwz8xwAKK rClCPZqFdmHxG1MjTpeMjGrereiJ9fUM4z/RWzZC1a6CgvsnH1A2y1Q5 X-Gm-Gg: AYBFou3qEXOCNfSgqo78I3SmwgtpwypZozhHpoSNiP7X9kZpCYY3mxjrS7FBYsOyIjq 2IEmTCtSFVucjJ+0UKt2W7YCra4SgQbcjXeUdI9beSVbJpmk4oNH0tvHinyw5qY+hPn90EHRo2o 9eq/pUehc/+YAzAbsltygEKFlLh07nbQI64EV5wHEbMe+bnAT8j7Ddk3pdO5Ihl14GxvkNxR5u9 wWscrU4BaTYtHAwKtLIOC0ElATrzq2MMCNC3P74AHoqEPa0AZGdQnGPNJ79lhO4GFlbnnKJbWBt hl15fw5pLrAn9xtzMWpw+gKAQqf5EtueVSHiruisIH/dmukhiMsE2oqwGs+irSQRkalDttJ6bc/ spoFLwAxD6TYkb9+miykV/+qe8OGvcna0mkLd2omv0Vyaf99fhPoPhKm1XAoiLhNJGMjYHiMtTb RTJCCv5HmQ9dh67v+X6zYwbE+caMCxvuZoe9A0wz7/0KHt6W5nI7w3h6Nk3/X7VZt2sjdnPoVa8 iK/owC5+9Bb2theZ8gdLgXW7cBs0JU+qHwG5VWunEqWrntz4evlVIZVDjB4x6lAlD6hKv+fx+gm 9+5+ECAmY0trbNMkfQ4H6YEjE7lu X-Received: by 2002:a05:600c:588b:b0:4bb:643e:3b8a with SMTP id 5b1f17b1804b1-4bb643e3bd6mr54723335e9.17.1794697718472; Sat, 14 Nov 2026 15:08:38 -0800 (PST) Received: from m2.. ([37.142.149.161]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-49c5d03b10fsm14910018f8f.1.2026.11.14.15.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Nov 2026 15:08:37 -0800 (PST) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v3 06/16] HID: ft260: i2c: reduce bus-error message severity Date: Sun, 15 Nov 2026 01:07:50 +0200 Message-ID: <20261114230800.1344401-7-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261114230800.1344401-1-michael.zaidman@gmail.com> References: <20261114230800.1344401-1-michael.zaidman@gmail.com> X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver logged errors when the FT260 reported an I2C bus error or when ft260_i2c_write / ft260_smbus_write failed after such a status. That was meant to flag unexpected failures, but bus scans (i2cdetect, HWMON discovery, transceiver monitoring, and similar) hit missing devices routinely and should not fill dmesg with lines such as: ft260 0003:0403:6030.0001: ft260_i2c_write: failed with -5 Keep returning -EIO, but print those via ft260_dbg. Still use hid_err in ft260_hid_output_report_check_status for actual HID/USB transport failures, which are genuine errors. Drop the extra __func__ from the write-path ft260_dbg calls; the helper already prints the function name. Signed-off-by: Michael Zaidman --- v2: Fix for the issue reported by Sashiko: the write-path messages printed the function name twice, because ft260_dbg() already prints it. --- drivers/hid/hid-ft260.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index 13dbff661fab..270481766e2c 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -577,7 +577,7 @@ static int ft260_xfer_status(struct ft260_device *dev, u8 bus_busy) * to 1, bit 1 is also set to 1. */ if (report.bus_status & FT260_I2C_STATUS_ERROR) { - hid_err(hdev, "i2c bus error: %#02x\n", report.bus_status); + ft260_dbg("i2c bus error: %#02x\n", report.bus_status); return -EIO; } @@ -611,6 +611,7 @@ static int ft260_hid_output_report_check_status(struct ft260_device *dev, ret = ft260_hid_output_report(hdev, data, len); if (ret < 0) { + hid_err(hdev, "%s: failed with %d\n", __func__, ret); ft260_i2c_reset(hdev); return ret; } @@ -650,7 +651,6 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, int len, u8 flag) { int ret, wr_len, idx = 0; - struct hid_device *hdev = dev->hdev; struct ft260_i2c_write_request_report *rep = (struct ft260_i2c_write_request_report *)dev->i2c_wr_buf; @@ -681,7 +681,7 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, wr_len + 4); if (ret < 0) { - hid_err(hdev, "%s: failed with %d\n", __func__, ret); + ft260_dbg("failed with %d\n", ret); return ret; } @@ -697,7 +697,7 @@ static int ft260_i2c_write(struct ft260_device *dev, u8 addr, u8 *data, static int ft260_smbus_write(struct ft260_device *dev, u8 addr, u8 cmd, u8 *data, u8 data_len, u8 flag) { - int ret = 0; + int ret; int len = 4; struct ft260_i2c_write_request_report *rep = @@ -722,7 +722,7 @@ static int ft260_smbus_write(struct ft260_device *dev, u8 addr, u8 cmd, ret = ft260_hid_output_report_check_status(dev, (u8 *)rep, len); if (ret < 0) - hid_err(dev->hdev, "%s: failed with %d\n", __func__, ret); + ft260_dbg("failed with %d\n", ret); return ret; } -- 2.43.0