All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qiliang Yuan <qiliang.yuan@linux.dev>
To: "Martin K. Petersen" <mkp@kernel.org>,
	Shuah Khan <shuah@kernel.org>,  Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	 Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	 target-devel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	 linux-doc@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	 io-uring@vger.kernel.org,
	Mike Christie <michael.christie@oracle.com>,
	 Bodo Stroesser <bostroesser@gmail.com>,
	Ming Lei <tom.leiming@gmail.com>,
	 Qiliang Yuan <qiliang.yuan@linux.dev>
Subject: [PATCH RFC 14/18] scsi: target: uring: Handle WRITE SAME
Date: Sun, 15 Nov 2026 19:18:07 -0500	[thread overview]
Message-ID: <20261115-feat-target-core-uring-v1-14-28cdc137eac6@linux.dev> (raw)
In-Reply-To: <20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev>

target_core_uring does not set execute_write_same(), so the core rejects
WRITE SAME without the UNMAP bit.

Initiators use it to zero or initialize ranges without sending the data
for every block.

Add TCMUR_OP_WRITE_SAME. The descriptor carries the range to fill, and
the data of the command is the one block to repeat. Accept up to 65536
blocks per command.

Signed-off-by: Qiliang Yuan <qiliang.yuan@linux.dev>
---
 drivers/target/target_core_uring.c     | 14 ++++++++++++++
 include/uapi/linux/target_core_uring.h |  9 +++++----
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/drivers/target/target_core_uring.c b/drivers/target/target_core_uring.c
index 366c5e9820956..42283a1ae1512 100644
--- a/drivers/target/target_core_uring.c
+++ b/drivers/target/target_core_uring.c
@@ -30,6 +30,8 @@
 #define TCMUR_VERSION		"1.0"
 #define TCMUR_MINORS		(1U << MINORBITS)
 #define TCMUR_MAX_IO_SIZE	(4U << 20)
+/* Limit one WRITE SAME to this many blocks */
+#define TCMUR_MAX_WRITE_SAME_LEN	0x10000
 #define TCMUR_DEF_QUEUE_DEPTH	128
 #define TCMUR_DEF_BLOCK_SIZE	512
 #define TCMUR_DEF_CMD_TIMEOUT	30
@@ -295,6 +297,16 @@ static sense_reason_t tcmur_execute_unmap(struct se_cmd *se_cmd, sector_t lba,
 	return tcmd.status ? TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE : 0;
 }
 
+static sense_reason_t tcmur_execute_write_same(struct se_cmd *se_cmd)
+{
+	u32 block_size = se_cmd->se_dev->dev_attrib.block_size;
+
+	return tcmur_submit(se_cmd, TCMUR_OP_WRITE_SAME,
+			    se_cmd->t_task_lba * block_size,
+			    (u64)sbc_get_write_same_sectors(se_cmd) * block_size,
+			    se_cmd->t_data_sg, se_cmd->t_data_nents);
+}
+
 static bool tcmur_configure_unmap(struct se_device *dev)
 {
 	dev->dev_attrib.max_unmap_lba_count = UINT_MAX /
@@ -813,6 +825,7 @@ static int tcmur_configure_device(struct se_device *dev)
 	dev->dev_attrib.hw_block_size = udev->block_size;
 	dev->dev_attrib.hw_max_sectors = TCMUR_MAX_IO_SIZE / udev->block_size;
 	dev->dev_attrib.hw_queue_depth = udev->nr_queues * udev->queue_depth;
+	dev->dev_attrib.max_write_same_len = TCMUR_MAX_WRITE_SAME_LEN;
 	dev->dev_attrib.is_nonrot = 1;
 
 	udev->cdev_dev.devt = MKDEV(MAJOR(tcmur_devt), udev->dev_id);
@@ -979,6 +992,7 @@ static struct exec_cmd_ops tcmur_exec_cmd_ops = {
 	.execute_rw		= tcmur_execute_rw,
 	.execute_sync_cache	= tcmur_execute_sync_cache,
 	.execute_unmap		= tcmur_execute_unmap,
+	.execute_write_same	= tcmur_execute_write_same,
 };
 
 static sense_reason_t tcmur_parse_cdb(struct se_cmd *se_cmd)
diff --git a/include/uapi/linux/target_core_uring.h b/include/uapi/linux/target_core_uring.h
index 9df10558cfa9e..469340b152f15 100644
--- a/include/uapi/linux/target_core_uring.h
+++ b/include/uapi/linux/target_core_uring.h
@@ -69,6 +69,7 @@ enum tcmur_io_op {
 	TCMUR_OP_WRITE,
 	TCMUR_OP_FLUSH,
 	TCMUR_OP_UNMAP,
+	TCMUR_OP_WRITE_SAME,
 };
 
 /* Put the write on stable storage before completing it */
@@ -80,7 +81,7 @@ enum tcmur_io_op {
  * @flags:	TCMUR_IO_F_*
  * @offset:	Start of the range in bytes
  * @len:	Length of the range in bytes
- * @data_len:	Bytes of data to transfer
+ * @data_len:	Bytes of data to transfer; one block for TCMUR_OP_WRITE_SAME
  * @reserved:	Zero
  *
  * The descriptors of a queue form an array indexed by tag, which the server
@@ -99,9 +100,9 @@ struct tcmur_io_desc {
 	(TCMUR_MAX_QUEUE_DEPTH * sizeof(struct tcmur_io_desc))
 
 /*
- * The data of a command is read (TCMUR_OP_WRITE) or written
- * (TCMUR_OP_READ) with pread()/pwrite() on the file, at the position
- * returned by tcmur_buf_pos().
+ * The data of a command is read (TCMUR_OP_WRITE, TCMUR_OP_WRITE_SAME) or
+ * written (TCMUR_OP_READ) with pread()/pwrite() on the file, at the
+ * position returned by tcmur_buf_pos().
  */
 #define TCMUR_BUF_TAG_SHIFT	32
 #define TCMUR_BUF_QID_SHIFT	48

-- 
2.43.0


  parent reply	other threads:[~2026-11-16  0:19 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  0:17 [PATCH RFC 00/18] scsi: target: Add target_core_uring, an io_uring based user backstore Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 01/18] scsi: target: uring: Introduce " Qiliang Yuan
2026-11-16  0:38   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 02/18] scsi: target: uring: Allocate per-queue command descriptors Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 03/18] scsi: target: uring: Create a character device per backstore device Qiliang Yuan
2026-11-16  0:33   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 04/18] scsi: target: uring: Map the command descriptors into the server Qiliang Yuan
2026-11-16  0:17 ` [PATCH RFC 05/18] scsi: target: uring: Queue commands until a server fetches them Qiliang Yuan
2026-11-16  0:46   ` sashiko-bot
2026-11-16  0:17 ` [PATCH RFC 06/18] scsi: target: uring: Hand commands out through TCMUR_IO_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 07/18] scsi: target: uring: Complete commands with TCMUR_IO_COMMIT_AND_FETCH Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 08/18] scsi: target: uring: Copy command data with pread() and pwrite() Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 09/18] scsi: target: uring: Fail in-flight commands when the server exits Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 10/18] scsi: target: uring: Time out commands the server does not complete Qiliang Yuan
2026-11-16  0:41   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 11/18] scsi: target: uring: Drop aborted commands that are still queued Qiliang Yuan
2026-11-16  0:37   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 12/18] scsi: target: uring: Support SYNCHRONIZE CACHE Qiliang Yuan
2026-11-16  0:40   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 13/18] scsi: target: uring: Implement UNMAP Qiliang Yuan
2026-11-16  0:45   ` sashiko-bot
2026-11-16  0:18 ` Qiliang Yuan [this message]
2026-11-16  0:44   ` [PATCH RFC 14/18] scsi: target: uring: Handle WRITE SAME sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 15/18] scsi: target: uring: Register command data as io_uring fixed buffers Qiliang Yuan
2026-11-16  0:18 ` [PATCH RFC 16/18] selftests: target_core_uring: Add a minimal server Qiliang Yuan
2026-11-16  1:03   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 17/18] selftests: target_core_uring: Test a device exported through tcm_loop Qiliang Yuan
2026-11-16  0:49   ` sashiko-bot
2026-11-16  0:18 ` [PATCH RFC 18/18] Documentation: target: Describe the uring backstore Qiliang Yuan
2026-11-16  2:32 ` [PATCH RFC 00/18] scsi: target: Add target_core_uring, an io_uring based user backstore Ming Lei
2026-11-17  2:46   ` Qiliang Yuan
2026-11-18  1:40     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261115-feat-target-core-uring-v1-14-28cdc137eac6@linux.dev \
    --to=qiliang.yuan@linux.dev \
    --cc=axboe@kernel.dk \
    --cc=bostroesser@gmail.com \
    --cc=corbet@lwn.net \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mkp@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=target-devel@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.