All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhefu Peng <ilskdw@gmail.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, kuniyu@google.com,
	mschiffer@universe-factory.net
Subject: Re: [PATCH net v2] vxlan: reset the remote's dst cache when snooping moves a MAC
Date: Sun, 15 Nov 2026 12:06:00 +0800	[thread overview]
Message-ID: <20261115040600.61033-1-ilskdw@gmail.com> (raw)
In-Reply-To: <179470552404.2199510.13614872178874456081@kernel.org>

> [Severity: Medium]
> Can a concurrent transmit still put the old remote's route back into the
> cache after this reset?

Yes, the window exists: a transmit that read the old remote_ip before
the reset and reaches dst_cache_get() in a later jiffy refills the
cache with the old route. vxlan_fdb_replace() and the other tunnel
users that reset the cache after changing parameters have the same
window. Closing it needs a change to how dst_cache tracks freshness,
which is out of scope for this fix. Without the patch every move uses
the stale route; with it only this race does.

> [Severity: Medium]
> Does this overwrite a user-configured egress interface with 0?

Yes, this is a regression, and v4 has the same code. v5 compares
remote_ifindex in the early return only for link-local sources, so
traffic from the remote of an entry with a "via" device takes the early
return and the device stays set. The selftest gets a case for it.

pw-bot: cr

      reply	other threads:[~2026-11-15  4:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 15:30 [PATCH net v2] vxlan: reset the remote's dst cache when snooping moves a MAC CMGS
2026-11-10 16:44 ` Nicolas Dichtel
2026-11-10 21:34   ` Zhefu Peng
2026-11-15  1:18 ` netdev-bot+sashiko
2026-11-15  4:06   ` Zhefu Peng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261115040600.61033-1-ilskdw@gmail.com \
    --to=ilskdw@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=mschiffer@universe-factory.net \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.