From: Junjie Cao <junjie.cao@linux.dev>
To: Tommaso Califano <tcalifano@redhat.com>
Cc: qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-stable@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Junjie Cao" <junjie.cao@linux.dev>
Subject: Re: [PATCH 9/9] hw/usb/dev-mtp: Stop processing SendObjectInfo after an error
Date: Sun, 15 Nov 2026 08:28:19 -0600 [thread overview]
Message-ID: <20261115142819.1299849-1-junjie.cao@linux.dev> (raw)
In-Reply-To: <20261112174907.158825-10-tcalifano@redhat.com>
On Thu, Nov 12, 2026 at 06:49:06PM +0100, Tommaso Califano wrote:
> When SendObjectInfo fails its checks, usb_mtp_command() queues an error
> response and then falls through. It still allocates s->data_out. The
> data phase is then dropped because a result is pending, so s->data_out
> is never released.
The guest cannot read that error on master: while s->data_out is
set, usb_mtp_handle_data() stalls every BULK IN, and the next command
with it. With this patch the response carries the error code and the
next command works.
Reviewed-by: Junjie Cao <junjie.cao@linux.dev>
Tested-by: Junjie Cao <junjie.cao@linux.dev>
prev parent reply other threads:[~2026-11-15 14:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 17:48 [PATCH 0/9] hw/usb/dev-mtp: Collection of bug fixes Tommaso Califano
2026-11-12 17:48 ` [PATCH 1/9] hw/usb/dev-mtp: Fix recursive delete of directories Tommaso Califano
2026-11-15 14:27 ` Junjie Cao
2026-11-12 17:48 ` [PATCH 2/9] hw/usb/dev-mtp: Reset pending write state on cancel, reset and error Tommaso Califano
2026-11-13 8:33 ` marcandre.lureau
2026-11-13 11:46 ` Tommaso Califano
2026-11-12 17:49 ` [PATCH 3/9] hw/usb/dev-mtp: Check length of class control request Tommaso Califano
2026-11-13 8:33 ` marcandre.lureau
2026-11-12 17:49 ` [PATCH 4/9] hw/usb/dev-mtp: Handle invalid characters in utf16_to_str() Tommaso Califano
2026-11-13 8:33 ` marcandre.lureau
2026-11-13 13:16 ` Tommaso Califano
2026-11-12 17:49 ` [PATCH 5/9] hw/usb/dev-mtp: Validate container length on first data packet Tommaso Califano
2026-11-13 8:33 ` marcandre.lureau
2026-11-13 13:18 ` Tommaso Califano
2026-11-12 17:49 ` [PATCH 6/9] hw/usb/dev-mtp: Detect end of SendObject data correctly Tommaso Califano
2026-11-15 14:28 ` Junjie Cao
2026-11-18 16:50 ` Tommaso Califano
2026-11-12 17:49 ` [PATCH 7/9] hw/usb/dev-mtp: Zero-initialize command and params in handle_data Tommaso Califano
2026-11-12 17:49 ` [PATCH 8/9] hw/usb/dev-mtp: Fix assert failures in usb_mtp_write_metadata() Tommaso Califano
2026-11-12 17:49 ` [PATCH 9/9] hw/usb/dev-mtp: Stop processing SendObjectInfo after an error Tommaso Califano
2026-11-15 14:28 ` Junjie Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115142819.1299849-1-junjie.cao@linux.dev \
--to=junjie.cao@linux.dev \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=tcalifano@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.