From: SJ Park <sj@kernel.org>
To: sashiko-bot@kernel.org
Cc: SJ Park <sj@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [RFC PATCH 03/27] mm/damon/core: introduce damon_submit_report()
Date: Sun, 15 Nov 2026 13:23:30 -0800 [thread overview]
Message-ID: <20261115212331.101376-1-sj@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-215851@kernel.org>
On Sun, 15 Nov 2026 20:42:40 +0000 sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issues to consider:
> - [High] mm/damon/core: out-of-bounds write in damon_submit_report() on
> queue wrap
> - [Low] mm/damon/core: missing Return section in damon_submit_report()
> kernel-doc
> --
>
> commit bcb278386fb51304d0c224892db9744bf9e27c8f
> Author: SJ Park <sj@kernel.org>
>
> mm/damon/core: introduce damon_submit_report()
>
> This commit adds damon_submit_report() to enqueue a data attribute report
> into the DAMON internal report queue using CAS-based try-locking.
>
> > diff --git a/mm/damon/core.c b/mm/damon/core.c
> > index 3f87a7eec442e..06b85d00e38d9 100644
> > --- a/mm/damon/core.c
> > +++ b/mm/damon/core.c
> > @@ -2353,6 +2353,36 @@ struct damon_report_queue {
> >
> > struct damon_report_queue damon_report_queue;
> >
> > +/**
> > + * damon_submit_report() - Enqueue a given report to DAMON internal buffer.
> > + * @report: The report to enqueue.
> > + *
> > + * This function can be called from any context including the NMI context.
> > + */
> > +int damon_submit_report(struct damon_report *report)
>
> [Severity: Low]
> This isn't a bug, but the kernel-doc comment for damon_submit_report() is
> missing a Return: section describing the 0 and -EBUSY return values, which
> triggers a kernel-doc warning under W=2 builds.
Nice catch, I will add Return: comment.
>
> > +{
> > + struct damon_report_queue *queue;
> > + int lock_old_val;
> > + unsigned int tail;
> > +
> > + queue = &damon_report_queue;
> > + report->jiffies = jiffies;
> > + lock_old_val = atomic_cmpxchg(&queue->lock, 0, 1);
> > + if (lock_old_val)
> > + return -EBUSY;
> > +
> > + tail = queue->tail;
> > + if (tail == queue->size)
> > + tail = 0;
> > + queue->reports[tail] = *report;
> > + queue->tail++;
>
> [Severity: High]
> Does this write out of bounds of queue->reports[] after the queue wraps?
>
> When queue->tail reaches queue->size, only the local variable tail is
> reset to 0 while queue->tail++ increments queue->tail to queue->size + 1.
> Every subsequent submission then bypasses the tail == queue->size check
> and writes past the end of the queue->reports heap array, corrupting
> adjacent slab memory. Updating queue->tail = tail + 1 would wrap the
> index properly.
Good catch. I will remove tail local variable and just use queue->tail.
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20261115202849.99134-1-sj@kernel.org?part=3
>
Thanks,
SJ
next prev parent reply other threads:[~2026-11-15 21:23 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 20:28 [RFC PATCH 00/27] mm/damon: let users report their data attribute findings SJ Park
2026-11-15 20:28 ` [RFC PATCH 01/27] mm/damon/api: introduce struct damon_report SJ Park
2026-11-15 20:34 ` sashiko-bot
2026-11-15 21:09 ` SJ Park
2026-11-15 20:28 ` [RFC PATCH 02/27] mm/damon/core: implement data attribute report queue SJ Park
2026-11-15 20:41 ` sashiko-bot
2026-11-15 21:17 ` SJ Park
2026-11-15 20:28 ` [RFC PATCH 03/27] mm/damon/core: introduce damon_submit_report() SJ Park
2026-11-15 20:42 ` sashiko-bot
2026-11-15 21:23 ` SJ Park [this message]
2026-11-15 20:28 ` [RFC PATCH 04/27] mm/damon/sysfs: add admin/reports/ directory SJ Park
2026-11-15 20:32 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 05/27] mm/damon/sysfs: add reports/producers/ directory SJ Park
2026-11-15 20:31 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 06/27] mm/damon/sysfs: add producers/nr_producers file SJ Park
2026-11-15 20:32 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 07/27] mm/damon/sysfs: implement report producer directory SJ Park
2026-11-15 20:33 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 08/27] mm/damon/sysfs: implement report producer type and state files SJ Park
2026-11-15 20:36 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 09/27] Docs/mm/damon/design: update for report system SJ Park
2026-11-15 20:36 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 10/27] Docs/admin-guide/mm/damon/usage: update for report producer sysfs SJ Park
2026-11-15 20:31 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 11/27] Docs/ABI/damon: update for report producer sysfs files SJ Park
2026-11-15 20:31 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 12/27] mm/damon/core: introduce DAMON_FILTER_TYPE_REPORT_MADE SJ Park
2026-11-15 20:36 ` sashiko-bot
2026-11-15 21:27 ` SJ Park
2026-11-15 20:28 ` [RFC PATCH 13/27] mm/damon/core: introduce damon_report_exist() SJ Park
2026-11-15 20:37 ` sashiko-bot
2026-11-15 21:35 ` SJ Park
2026-11-15 20:28 ` [RFC PATCH 14/27] mm/damon/paddr: support REPORT_MADE type probe filter SJ Park
2026-11-15 20:41 ` sashiko-bot
2026-11-15 21:40 ` SJ Park
2026-11-16 7:43 ` Aveline Noir
2026-11-16 15:05 ` SJ Park
2026-11-15 20:28 ` [RFC PATCH 15/27] mm/damon/sysfs: add filter_report_type file under probe filter directory SJ Park
2026-11-15 20:32 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 16/27] mm/damon/sysfs: support REPORT_MADE type probe filter setup SJ Park
2026-11-15 20:41 ` sashiko-bot
2026-11-15 21:42 ` SJ Park
2026-11-15 20:28 ` [RFC PATCH 17/27] Docs/mm/damon/design: update for report_made probe filter type SJ Park
2026-11-15 20:32 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 18/27] Docs/admin-guide/mm/damon/usage: update for REPORT_MADE probe filter SJ Park
2026-11-15 20:32 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 19/27] Docs/ABI/damon: " SJ Park
2026-11-15 20:32 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 20/27] mm/damon/api: introduce user_report report type SJ Park
2026-11-15 20:33 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 21/27] mm/damon/sysfs: add user_report support for report type input SJ Park
2026-11-15 20:33 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 22/27] mm/damon/sysfs: implement report producer addr_{start,end} files SJ Park
2026-11-15 20:34 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 23/27] mm/damon/sysfs: implement submit command for report producer SJ Park
2026-11-15 20:43 ` sashiko-bot
2026-11-15 21:43 ` SJ Park
2026-11-15 20:28 ` [RFC PATCH 24/27] selftests/damon/sysfs.sh: add basic tests for admin/reports/ SJ Park
2026-11-15 20:37 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 25/27] Docs/mm/damon/design: update for user report support SJ Park
2026-11-15 20:33 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 26/27] Docs/admin-guide/mm/damon/usage: update for user_report " SJ Park
2026-11-15 20:34 ` sashiko-bot
2026-11-15 20:28 ` [RFC PATCH 27/27] Docs/ABI/damon: " SJ Park
2026-11-15 20:34 ` sashiko-bot
2026-11-15 20:55 ` [RFC PATCH 00/27] mm/damon: let users report their data attribute findings SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115212331.101376-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-mm@kvack.org \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.