All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mark Hatle" <mark.hatle@amd.com>
To: <bitbake-devel@lists.openembedded.org>
Subject: [PATCH] runqueue: Don't defer setscene tasks behind already completed tasks
Date: Sun, 15 Nov 2026 15:09:56 -0700	[thread overview]
Message-ID: <20261115220956.758312-1-mark.hatle@amd.com> (raw)

When a task completes, the first setscene task deferred against it is
released and any others are re-deferred behind that task. If the released
task had already completed (e.g. its setscene was skipped due to a valid
stamp), it never completes again, so the re-deferred tasks are never
released. Setscene then can't finish until the deadlock fallback forces
each one, printing "Runqueue deadlocked on deferred tasks".

This shows up with three or more multiconfigs sharing a task hash. Skip
already completed tasks when picking the new blocker.

AI-Generated: Uses GitHub Copilot
Signed-off-by: Mark Hatle <mark.hatle@amd.com>
---
 lib/bb/runqueue.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
index ef95eb46b..2a6b099b8 100644
--- a/lib/bb/runqueue.py
+++ b/lib/bb/runqueue.py
@@ -2112,6 +2112,10 @@ class RunQueueExecute:
                     bb.debug(1, "Deferred task %s now buildable" % t)
                     del self.sq_deferred[t]
                     update_scenequeue_data([t], self.sqdata, self.rqdata, self.rq, self.cooker, self.stampcache, self, summary=False)
+                    # A task which already completed will never complete again so must
+                    # not become the new blocker, else the remaining tasks never get released
+                    if t in self.runq_complete:
+                        continue
                     found = t
                 else:
                     bb.debug(1, "Deferring %s after %s" % (t, found))
-- 
2.34.1


             reply	other threads:[~2026-11-15 22:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 22:09 Mark Hatle [this message]
2026-11-16 13:32 ` [bitbake-devel] [PATCH] runqueue: Don't defer setscene tasks behind already completed tasks Richard Purdie
2026-11-16 14:16   ` Mark Hatle
2026-11-17 11:50 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261115220956.758312-1-mark.hatle@amd.com \
    --to=mark.hatle@amd.com \
    --cc=bitbake-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.