From: James Lin <PingLei.Lin@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: "Alexander Deucher" <Alexander.Deucher@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Harry Wentland" <Harry.Wentland@amd.com>,
"James Lin" <PingLei.Lin@amd.com>,
"Melissa Wen" <mwen@igalia.com>,
"Viktor Jägersküpper" <viktor_jaegerskuepper@freenet.de>,
"Dan Wheeler" <daniel.wheeler@amd.com>,
"Timur Kristóf" <timur.kristof@gmail.com>,
"Alex Hung" <alex.hung@amd.com>,
"Leandro Ribeiro" <leandro.ribeiro@collabora.com>
Subject: [PATCH 2/2] drm/amd/display: advertise PIXEL_NONE and PREMULTI blend mode for DCE
Date: Mon, 16 Nov 2026 07:59:11 +0800 [thread overview]
Message-ID: <20261116001326.2360302-3-PingLei.Lin@amd.com> (raw)
In-Reply-To: <20261116001326.2360302-1-PingLei.Lin@amd.com>
From: Melissa Wen <mwen@igalia.com>
DCE can support PREMULTI and COVERAGE blend mode depending on its
generation, however current driver implementation either doesn't expose
more than primary and cursor plane, or doesn't program registers for any
blend mode other than PIXEL_NONE. To fix the missing-blend-mode-prop
warning according to current DCE plane caps, create blend mode property
with PIXEL_NONE and PREMULTI for primary planes. As long as the
background is black and there is no overlay plane, PIXEL_NONE and
PREMULTI are equivalent, and PREMULTI has been the mandatory/default
mode for years, so keep it to avoid regressions.
Fixes: 860e748bddcc ("drm: ensure blend mode supported if pixel format with alpha exposed")
Tested-by: Viktor Jägersküpper <viktor_jaegerskuepper@freenet.de>
Tested-by: Dan Wheeler <daniel.wheeler@amd.com> #v3
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
Reviewed-by: Leandro Ribeiro <leandro.ribeiro@collabora.com> #v2
Signed-off-by: Melissa Wen <mwen@igalia.com>
Link: https://patch.msgid.link/20260826104143.39077-4-mwen@igalia.com
(cherry picked from commit 332ad707e38fb82dd998b4d0782c15579e5784f1)
Signed-off-by: James Lin <PingLei.Lin@amd.com>
---
.../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 24 +++++++++++++------
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
index 9d7be2fd29aa..db07b6d9110c 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
@@ -2233,14 +2233,24 @@ int amdgpu_dm_plane_init(struct amdgpu_display_manager *dm,
if (res)
return res;
- /* TODO: Check which blend modes are supported in DCE-generation
- * planes, i.e. DC_PLANE_TYPE_DCE_RGB/UNDERLAY and expose blend mode
- * property accordingly.
+ /* Blend mode support varies on DCE generations according to HW caps
+ * and number of planes per CRTC. However, as current driver
+ * implementation only creates one primary and one cursor plane per
+ * CRTC for DCE (overlay is only created if
+ * DC_PLANE_TYPE_DCN_UNIVERSAL), the primary plane blend mode is
+ * ignored across DCE versions. Keep PREMULTI to avoid uAPI
+ * regressions: it was the default/mandatory mode for many years and,
+ * with no overlay plane, primary composes on top of a black
+ * background, where PREMULTI and PIXEL_NONE are equivalent.
*/
- if ((plane->type == DRM_PLANE_TYPE_OVERLAY ||
- plane->type == DRM_PLANE_TYPE_PRIMARY) &&
- plane_cap && plane_cap->per_pixel_alpha &&
- plane_cap->type == DC_PLANE_TYPE_DCN_UNIVERSAL) {
+ if (plane_cap && plane_cap->type != DC_PLANE_TYPE_DCN_UNIVERSAL) {
+ unsigned int blend_caps = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
+ BIT(DRM_MODE_BLEND_PREMULTI);
+
+ drm_plane_create_blend_mode_property(plane, blend_caps);
+ } else if ((plane->type == DRM_PLANE_TYPE_OVERLAY ||
+ plane->type == DRM_PLANE_TYPE_PRIMARY) &&
+ plane_cap && plane_cap->per_pixel_alpha) {
unsigned int blend_caps = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
BIT(DRM_MODE_BLEND_PREMULTI) |
BIT(DRM_MODE_BLEND_COVERAGE);
--
2.43.0
next prev parent reply other threads:[~2026-11-16 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 23:59 [PATCH 0/2] drm/amd/display: sync blend mode property fixes from drm-next James Lin
2026-11-15 23:59 ` [PATCH 1/2] drm/amd/display: fix missing blend-mode-prop warning for DCN James Lin
2026-11-15 23:59 ` James Lin [this message]
2026-11-16 19:38 ` [PATCH 2/2] drm/amd/display: advertise PIXEL_NONE and PREMULTI blend mode for DCE sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116001326.2360302-3-PingLei.Lin@amd.com \
--to=pinglei.lin@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=alex.hung@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.wheeler@amd.com \
--cc=leandro.ribeiro@collabora.com \
--cc=mwen@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=timur.kristof@gmail.com \
--cc=viktor_jaegerskuepper@freenet.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.