From: "William A. Kennington III" <william@wkennington.com>
To: Michal Pecio <michal.pecio@gmail.com>
Cc: "William A. Kennington III" <william@wkennington.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: ehci: skip companion handoff when no companion exists
Date: Mon, 16 Nov 2026 06:43:51 +0000 [thread overview]
Message-ID: <20261116064351.1038057-1-william@wkennington.com> (raw)
In-Reply-To: <20261115075359.39ec8f71.michal.pecio@gmail.com>
On Sun, Nov 15, 2026 at 07:53:59AM +0100, Michal Pecio wrote:
> That's for Alan to decide, but it seems that whenever you use
> ehci->no_companion, you always add "|| ehci_is_TD(ehci)", and this
> is unlikely to change since HCs with TT don't need companions.
>
> So ehci_is_TDI() together with its associated comment could be
> moved to ehci_has_companion(). Then you no longer need those funny
> comments like "without companion there is no companion" and the
> code becomes somewhat simpler too.
Seems reasonable, let me just send out a v2.
prev parent reply other threads:[~2026-11-16 6:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 5:16 [PATCH] usb: ehci: skip companion handoff when no companion exists William A. Kennington III
2026-11-14 5:24 ` sashiko-bot
2026-11-14 19:44 ` Alan Stern
2026-11-15 6:53 ` Michal Pecio
2026-11-16 6:43 ` William A. Kennington III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116064351.1038057-1-william@wkennington.com \
--to=william@wkennington.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.pecio@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.